WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
91081
[WK2] Add Vibration API integration to WebContext and WebPage
https://bugs.webkit.org/show_bug.cgi?id=91081
Summary
[WK2] Add Vibration API integration to WebContext and WebPage
Sudarsana Nagineni (babu)
Reported
2012-07-12 05:44:12 PDT
Integrate Vibration API to WebContext, WebPage and properly route messages to WebVibrationProxy.
Attachments
Patch
(7.48 KB, patch)
2012-07-12 07:17 PDT
,
Sudarsana Nagineni (babu)
no flags
Details
Formatted Diff
Diff
Patch
(7.50 KB, patch)
2012-07-12 14:16 PDT
,
Sudarsana Nagineni (babu)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1
2012-07-12 07:17:43 PDT
Created
attachment 151947
[details]
Patch
Chris Dumez
Comment 2
2012-07-12 11:18:32 PDT
Comment on
attachment 151947
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=151947&action=review
Otherwise, LGTM.
> Source/WebKit2/UIProcess/WebContext.h:350 > + RefPtr<WebVibrationProxy> m_vibrationProxy;
I would move this up with the other proxy members.
Sudarsana Nagineni (babu)
Comment 3
2012-07-12 14:16:27 PDT
Created
attachment 152058
[details]
Patch Take Chris's feedback into consideration and rebase on master.
WebKit Review Bot
Comment 4
2012-07-19 15:57:41 PDT
Comment on
attachment 152058
[details]
Patch Clearing flags on attachment: 152058 Committed
r123158
: <
http://trac.webkit.org/changeset/123158
>
WebKit Review Bot
Comment 5
2012-07-19 15:57:46 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug