Bug 91081 - [WK2] Add Vibration API integration to WebContext and WebPage
Summary: [WK2] Add Vibration API integration to WebContext and WebPage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks: 91077
  Show dependency treegraph
 
Reported: 2012-07-12 05:44 PDT by Sudarsana Nagineni (babu)
Modified: 2012-07-19 15:57 PDT (History)
6 users (show)

See Also:


Attachments
Patch (7.48 KB, patch)
2012-07-12 07:17 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff
Patch (7.50 KB, patch)
2012-07-12 14:16 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-07-12 05:44:12 PDT
Integrate Vibration API to WebContext, WebPage and properly route messages to WebVibrationProxy.
Comment 1 Sudarsana Nagineni (babu) 2012-07-12 07:17:43 PDT
Created attachment 151947 [details]
Patch
Comment 2 Chris Dumez 2012-07-12 11:18:32 PDT
Comment on attachment 151947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151947&action=review

Otherwise, LGTM.

> Source/WebKit2/UIProcess/WebContext.h:350
> +    RefPtr<WebVibrationProxy> m_vibrationProxy;

I would move this up with the other proxy members.
Comment 3 Sudarsana Nagineni (babu) 2012-07-12 14:16:27 PDT
Created attachment 152058 [details]
Patch

Take Chris's feedback into consideration and rebase on master.
Comment 4 WebKit Review Bot 2012-07-19 15:57:41 PDT
Comment on attachment 152058 [details]
Patch

Clearing flags on attachment: 152058

Committed r123158: <http://trac.webkit.org/changeset/123158>
Comment 5 WebKit Review Bot 2012-07-19 15:57:46 PDT
All reviewed patches have been landed.  Closing bug.