Bug 91072 - [User Timing] Expose User Timing getter via Performance Timeline interface
Summary: [User Timing] Expose User Timing getter via Performance Timeline interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 04:21 PDT by pdeng6
Modified: 2012-10-22 15:37 PDT (History)
28 users (show)

See Also:


Attachments
Patch (9.23 KB, patch)
2012-10-19 12:05 PDT, pdeng6
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pdeng6 2012-07-12 04:21:23 PDT
Since getMarks()/getMeasures() functions were removed from User Timing spec.
we only need to expose getters via performance timeline getEntries, getEntriesByType, getEntriesByName.
Comment 1 pdeng6 2012-10-19 12:05:53 PDT
Created attachment 169669 [details]
Patch
Comment 2 Tony Gentilcore 2012-10-19 15:21:46 PDT
Comment on attachment 169669 [details]
Patch

Patch looks good, but what about tests?
Comment 3 pdeng6 2012-10-19 17:40:02 PDT
(In reply to comment #2)
> (From update of attachment 169669 [details])
> Patch looks good, but what about tests?

all user timing test cases have been landed in r131693. (https://bugs.webkit.org/show_bug.cgi?id=90963)

Including performance timeline interface(for user timing only).

do we need more?
Comment 4 WebKit Review Bot 2012-10-22 15:37:09 PDT
Comment on attachment 169669 [details]
Patch

Clearing flags on attachment: 169669

Committed r132147: <http://trac.webkit.org/changeset/132147>
Comment 5 WebKit Review Bot 2012-10-22 15:37:14 PDT
All reviewed patches have been landed.  Closing bug.