When subpixel layout is enabled, the two functions ceiledLayoutUnit and roundedLayoutUnit both returns the flooredLayoutUnit instead of ceiled or rounded values. The function FractionalUnit::fromFloatCeil was recently added to solve the same problem in updatePreferredWidth in RenderBlock.cpp, and can be reused to fix ceiledLayoutUnit.
Created attachment 151892 [details] Patch
Comment on attachment 151892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151892&action=review Good catch, thank you! > Source/WebCore/platform/FractionalLayoutUnit.h:97 > + static FractionalLayoutUnit fromFloatRound(float value) We probably want to assert that the value is in bounds here too.
(In reply to comment #2) > (From update of attachment 151892 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151892&action=review > > Good catch, thank you! > > > Source/WebCore/platform/FractionalLayoutUnit.h:97 > > + static FractionalLayoutUnit fromFloatRound(float value) > > We probably want to assert that the value is in bounds here too. I believe in this case the values are asserted to be in bounds in the constructor, so I don't think we need to assert it in the fromFloatRound function.
(In reply to comment #3) > I believe in this case the values are asserted to be in bounds in the constructor, so I don't think we need to assert it in the fromFloatRound function. You are right, that should be enough. Thanks.
Comment on attachment 151892 [details] Patch rs=me based on eae's unofficial review.
Comment on attachment 151892 [details] Patch Clearing flags on attachment: 151892 Committed r123626: <http://trac.webkit.org/changeset/123626>
All reviewed patches have been landed. Closing bug.