Bug 91030 - Compilation error with GLES2 when using gl2ext.h from ANGLE.
Summary: Compilation error with GLES2 when using gl2ext.h from ANGLE.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-11 15:49 PDT by Noam Rosenthal
Modified: 2012-07-18 14:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.13 KB, patch)
2012-07-11 15:55 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (2.07 KB, patch)
2012-07-11 17:42 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (2.02 KB, patch)
2012-07-11 17:52 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-07-11 15:49:23 PDT
Compilation error with GLES2 when the gl2.h driver is of an older version.
Comment 1 Noam Rosenthal 2012-07-11 15:55:25 PDT
Created attachment 151808 [details]
Patch
Comment 2 Noam Rosenthal 2012-07-11 17:09:48 PDT
Comment on attachment 151808 [details]
Patch

Clearing flags for now.
Comment 3 Noam Rosenthal 2012-07-11 17:42:20 PDT
Created attachment 151825 [details]
Patch
Comment 4 Noam Rosenthal 2012-07-11 17:52:34 PDT
Created attachment 151827 [details]
Patch
Comment 5 Kenneth Russell 2012-07-11 17:56:50 PDT
Comment on attachment 151827 [details]
Patch

Looks like the best available solution at this point. r=me
Comment 6 WebKit Review Bot 2012-07-11 20:54:27 PDT
Comment on attachment 151827 [details]
Patch

Clearing flags on attachment: 151827

Committed r122413: <http://trac.webkit.org/changeset/122413>
Comment 7 WebKit Review Bot 2012-07-11 20:54:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Joshua Netterfield 2012-07-16 11:20:57 PDT
This breaks the BlackBerry build, so I am trying to find a solution.

We have a version of gl2ext.h from 2010 which defines the problematic symbols with -PROC. The newest version from the Khronos website (http://www.khronos.org/registry/gles/api/2.0/gl2ext.h) also defines the symbols in conflict with -PROC. The ANGLE header, which according to the revision statement is newer than ours but older than Khronos' defines the symbols in conflict without -PROC.

Does this conflict only affect BlackBerry? Are any of the headers wrong?
Comment 9 Kenneth Russell 2012-07-18 14:03:55 PDT
(In reply to comment #8)
> This breaks the BlackBerry build, so I am trying to find a solution.
> 
> We have a version of gl2ext.h from 2010 which defines the problematic symbols with -PROC. The newest version from the Khronos website (http://www.khronos.org/registry/gles/api/2.0/gl2ext.h) also defines the symbols in conflict with -PROC. The ANGLE header, which according to the revision statement is newer than ours but older than Khronos' defines the symbols in conflict without -PROC.

The Khronos gl2ext.h header was just updated to add the -PROC suffix to these symbols based on a bug I filed. Before that, the symbols were defined without the PROC suffix for quite some time -- I'm pretty sure since before 2010.

> Does this conflict only affect BlackBerry? Are any of the headers wrong?

Yes, the conflict currently only affects Blackberry. You should add an #ifdef to the WebCore code to get things compiling.