Bug 91018 - Failure to dispatch didFinishLoadForFrame if font load fails synchronously
Summary: Failure to dispatch didFinishLoadForFrame if font load fails synchronously
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-07-11 14:40 PDT by Antti Koivisto
Modified: 2012-07-12 04:41 PDT (History)
8 users (show)

See Also:

Attachments
patch (1.83 KB, patch)
2012-07-11 15:07 PDT, Antti Koivisto 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-07-11 14:40:20 PDT 
If a font load fails synchronously (by willSendRequest delegate) we might fail to dispatch didFinishLoadForFrame.
Normally checkLoadComplete would be invoked by DocumentLoader::removeSubresourceLoader but in case of a synchronous failure
add/removeSubresourceLoader is not called at all.
Comment 1 Antti Koivisto 2012-07-11 14:41:57 PDT 
<rdar://problem/11822378>
Comment 2 Antti Koivisto 2012-07-11 15:07:28 PDT 
Created attachment 151793 [details]
patch

I'll see about making an API test though conditions where this occur a fairly specific.
Comment 3 Pratik Solanki 2012-07-11 15:29:41 PDT 
Comment on attachment 151793 [details]
patch

Looks good to me.
Comment 4 Enrica Casucci 2012-07-11 17:40:49 PDT 
Comment on attachment 151793 [details]
patch

This looks good to me.
Comment 5 Antti Koivisto 2012-07-12 04:41:46 PDT 
http://trac.webkit.org/changeset/122446