Bug 91011 – Simplify css3/flexbox/repaint-rtl-column.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

Simplify css3/flexbox/repaint-rtl-column.html

[Ojan Vafai]

Created attachment 151762 [details]
Patch

[Tony Chang]

Comment on attachment 151762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151762&action=review

> LayoutTests/css3/flexbox/repaint-rtl-column.html:18
> +    height: 350px;

I'm not sure we should hard code a height here.  The original bug was that we would leave some text in the middle of the page that didn't get cleared by the repaint.  You might want to try reverting the code change associated with this test to verify that this new test triggers the failure.

> LayoutTests/css3/flexbox/repaint-rtl-column.html:36
> +    document.getElementById("content").style.webkitFlex = "5";
> +    if (window.testRunner)
> +        testRunner.notifyDone();

The test used to set the flex to 2 different values, but now only sets it once.  Is that the same?

[Ojan Vafai]

Created attachment 151776 [details]
Patch

[Ojan Vafai]

Comment on attachment 151762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151762&action=review

>> LayoutTests/css3/flexbox/repaint-rtl-column.html:18
>> +    height: 350px;
> 
> I'm not sure we should hard code a height here.  The original bug was that we would leave some text in the middle of the page that didn't get cleared by the repaint.  You might want to try reverting the code change associated with this test to verify that this new test triggers the failure.

As discussed in person, this is changing the content of the flex item. It's the flex item's height that changes.

>> LayoutTests/css3/flexbox/repaint-rtl-column.html:36
>> +        testRunner.notifyDone();
> 
> The test used to set the flex to 2 different values, but now only sets it once.  Is that the same?

I added back in the two values and the setTimeouts.

[Tony Chang]

Comment on attachment 151776 [details]
Patch

Please mention in the ChangeLog that this also reveals a bug in repainting outline.

[Ojan Vafai]

Committed r122374: <http://trac.webkit.org/changeset/122374>