WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
91002
WebPage::touchEvent() should use Platform::TouchEvent's toString() for debugging.
https://bugs.webkit.org/show_bug.cgi?id=91002
Summary
WebPage::touchEvent() should use Platform::TouchEvent's toString() for debugg...
Pawel Chomicki
Reported
2012-07-11 12:52:20 PDT
toString() provide's a more thorough description of the TouchEvent and is more useful for debugging purposes.
Attachments
Patch with ChangeLog
(3.71 KB, patch)
2012-07-11 13:02 PDT
,
Pawel Chomicki
no flags
Details
Formatted Diff
Diff
Patch with ChangeLog
(3.74 KB, patch)
2012-07-11 14:10 PDT
,
Pawel Chomicki
no flags
Details
Formatted Diff
Diff
Patch with ChangeLog
(3.78 KB, patch)
2012-07-11 14:15 PDT
,
Pawel Chomicki
rwlbuis
: review+
Details
Formatted Diff
Diff
Patch with ChangeLog
(3.78 KB, patch)
2012-07-11 14:37 PDT
,
Pawel Chomicki
rwlbuis
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Patch with ChangeLog
(3.78 KB, patch)
2012-07-11 17:23 PDT
,
Pawel Chomicki
no flags
Details
Formatted Diff
Diff
Patch with ChangeLog
(3.77 KB, patch)
2012-07-12 08:28 PDT
,
Pawel Chomicki
no flags
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Pawel Chomicki
Comment 1
2012-07-11 13:02:20 PDT
Created
attachment 151756
[details]
Patch with ChangeLog
Pawel Chomicki
Comment 2
2012-07-11 14:10:38 PDT
Created
attachment 151771
[details]
Patch with ChangeLog Previous patch was missing 'reviewed by' line in git log and ChangeLog.
Pawel Chomicki
Comment 3
2012-07-11 14:15:34 PDT
Created
attachment 151773
[details]
Patch with ChangeLog Forgot to git add ChangeLog file.
Rob Buis
Comment 4
2012-07-11 14:17:45 PDT
Comment on
attachment 151773
[details]
Patch with ChangeLog LGTM.
Pawel Chomicki
Comment 5
2012-07-11 14:37:01 PDT
Created
attachment 151782
[details]
Patch with ChangeLog
Rob Buis
Comment 6
2012-07-11 15:09:46 PDT
Comment on
attachment 151782
[details]
Patch with ChangeLog LGTM.
WebKit Review Bot
Comment 7
2012-07-11 15:15:52 PDT
Comment on
attachment 151782
[details]
Patch with ChangeLog Rejecting
attachment 151782
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ode: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 succeeded at 4124 (offset -15 lines). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/ChangeLog.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output:
http://queues.webkit.org/results/13208477
Pawel Chomicki
Comment 8
2012-07-11 17:23:06 PDT
Created
attachment 151821
[details]
Patch with ChangeLog
Pawel Chomicki
Comment 9
2012-07-12 08:28:21 PDT
Created
attachment 151963
[details]
Patch with ChangeLog
WebKit Review Bot
Comment 10
2012-07-12 09:36:14 PDT
Comment on
attachment 151963
[details]
Patch with ChangeLog Clearing flags on attachment: 151963 Committed
r122469
: <
http://trac.webkit.org/changeset/122469
>
WebKit Review Bot
Comment 11
2012-07-12 09:36:19 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug