Bug 91000 - REGRESSION (r122244): Overflow elements don't shrink as much as they should.
Summary: REGRESSION (r122244): Overflow elements don't shrink as much as they should.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
: 90965 91036 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-07-11 12:33 PDT by Dave Hyatt
Modified: 2012-07-13 13:54 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.46 KB, patch)
2012-07-11 12:37 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (5.93 KB, patch)
2012-07-11 14:22 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (6.85 KB, patch)
2012-07-12 10:39 PDT, Dave Hyatt
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2012-07-11 12:33:27 PDT
Regression from https://bugs.webkit.org/show_bug.cgi?id=90646.

I incorrectly analyzed the issue with Robert Hogan's negative margin patch and fooled myself into putting back in an incorrect minimum width check from long ago.

What should have happened in the test case I patched is that the overflow element should shrink to 0. The issue was that it exposed a bug in our clearing algorithm where
you could need a relayout even if you didn't actually move. This only occurs because the floats list is getting changed mid-layout because of negative margins.
Comment 1 Dave Hyatt 2012-07-11 12:37:37 PDT
Created attachment 151752 [details]
Patch
Comment 2 Dave Hyatt 2012-07-11 14:22:35 PDT
Created attachment 151775 [details]
Patch

New patch for EWS.
Comment 3 Dave Hyatt 2012-07-12 10:39:33 PDT
Created attachment 151993 [details]
Patch
Comment 4 Simon Fraser (smfr) 2012-07-12 10:43:54 PDT
Comment on attachment 151993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151993&action=review

> Source/WebCore/ChangeLog:23
> +        Reviewed by NOBODY (OOPS!).

This should go above the description.

> Source/WebCore/ChangeLog:25
> +        No new tests required, since the test in fast/block/float is now correctly covering the issue.

But was that test failing before?
Comment 5 Dave Hyatt 2012-07-12 11:47:12 PDT
Fixed in r122489.
Comment 6 Pavel Feldman 2012-07-13 03:32:31 PDT
*** Bug 90965 has been marked as a duplicate of this bug. ***
Comment 7 Andy Estes 2012-07-13 13:54:32 PDT
*** Bug 91036 has been marked as a duplicate of this bug. ***