Bug 90997 - Style Error in WebPage.cpp
Summary: Style Error in WebPage.cpp
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-11 11:26 PDT by Pawel Chomicki
Modified: 2012-07-12 07:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch with ChangeLog (1.94 KB, patch)
2012-07-11 11:40 PDT, Pawel Chomicki 		tonikitoo: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch with ChangeLog (2.03 KB, patch)
2012-07-11 12:24 PDT, Pawel Chomicki 		rwlbuis: review+
kpiascik: commit-queue-
Details | Formatted Diff | Diff
Patch with ChangeLog (2.03 KB, patch)
2012-07-11 14:35 PDT, Pawel Chomicki 		no flags Details | Formatted Diff | Diff
Patch with ChangeLog (2.03 KB, patch)
2012-07-11 14:36 PDT, Pawel Chomicki 		rwlbuis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch with ChangeLog (2.01 KB, patch)
2012-07-11 17:22 PDT, Pawel Chomicki 		tonikitoo: review-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Chomicki 2012-07-11 11:26:21 PDT 
Exta braces in one-line control clause.
Comment 1 Pawel Chomicki 2012-07-11 11:40:23 PDT 
Created attachment 151741 [details]
Patch with ChangeLog
Comment 2 Antonio Gomes 2012-07-11 11:41:56 PDT 
maybe the patch does not apply against ToT?
Comment 3 WebKit Review Bot 2012-07-11 11:47:12 PDT 
Comment on attachment 151741 [details]
Patch with ChangeLog

Rejecting attachment 151741 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
e: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/blackberry/Api/WebPage.cpp
Hunk #1 FAILED at 5642.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13208418
Comment 4 Pawel Chomicki 2012-07-11 12:24:21 PDT 
Created attachment 151749 [details]
Patch with ChangeLog

My apologies, I had forgotten to rebase the repository before writing my changes, which causes some errors when patching the changelog. This latest patch should work, however.
Comment 5 Rob Buis 2012-07-11 14:05:02 PDT 
Comment on attachment 151749 [details]
Patch with ChangeLog

LGTM.
Comment 6 Konrad Piascik 2012-07-11 14:18:34 PDT 
Comment on attachment 151749 [details]
Patch with ChangeLog

rebase your commit
Comment 7 Pawel Chomicki 2012-07-11 14:35:51 PDT 
Created attachment 151779 [details]
Patch with ChangeLog
Comment 8 Pawel Chomicki 2012-07-11 14:36:42 PDT 
Created attachment 151781 [details]
Patch with ChangeLog
Comment 9 Rob Buis 2012-07-11 15:10:14 PDT 
Comment on attachment 151781 [details]
Patch with ChangeLog

LGTM.
Comment 10 WebKit Review Bot 2012-07-11 15:14:30 PDT 
Comment on attachment 151781 [details]
Patch with ChangeLog

Rejecting attachment 151781 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
code: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/blackberry/Api/WebPage.cpp
Hunk #1 FAILED at 5760.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13207404
Comment 11 Pawel Chomicki 2012-07-11 17:22:26 PDT 
Created attachment 151819 [details]
Patch with ChangeLog
Comment 12 Kentaro Hara 2012-07-11 23:59:29 PDT 
(Though I am not intending to say a strong opinion since this is a blackberry patch, FYI,) basically WebKit does not accept only-style-fix patches, which just messes up history.
Comment 13 Antonio Gomes 2012-07-12 07:32:35 PDT 
(In reply to comment #12)
> (Though I am not intending to say a strong opinion since this is a blackberry patch, FYI,) basically WebKit does not accept only-style-fix patches, which just messes up history.

Agree.

Please fix it as part of another patch, or when effectively touching this piece of code.