RESOLVED WONTFIX 90997
Style Error in WebPage.cpp 
https://bugs.webkit.org/show_bug.cgi?id=90997
Summary Style Error in WebPage.cpp
Pawel Chomicki
Reported 2012-07-11 11:26:21 PDT
Exta braces in one-line control clause.
Attachments
Patch with ChangeLog (1.94 KB, patch)
2012-07-11 11:40 PDT, Pawel Chomicki 		tonikitoo: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch with ChangeLog (2.03 KB, patch)
2012-07-11 12:24 PDT, Pawel Chomicki 		rwlbuis: review+
kpiascik: commit-queue-
DetailsFormatted DiffDiff
Patch with ChangeLog (2.03 KB, patch)
2012-07-11 14:35 PDT, Pawel Chomicki 		no flags
DetailsFormatted DiffDiff
Patch with ChangeLog (2.03 KB, patch)
2012-07-11 14:36 PDT, Pawel Chomicki 		rwlbuis: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch with ChangeLog (2.01 KB, patch)
2012-07-11 17:22 PDT, Pawel Chomicki 		tonikitoo: review-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Pawel Chomicki
Comment 1 2012-07-11 11:40:23 PDT
Created attachment 151741 [details] Patch with ChangeLog
Antonio Gomes
Comment 2 2012-07-11 11:41:56 PDT
maybe the patch does not apply against ToT?
WebKit Review Bot
Comment 3 2012-07-11 11:47:12 PDT
Comment on attachment 151741 [details] Patch with ChangeLog Rejecting attachment 151741 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 FAILED at 5642. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13208418
Pawel Chomicki
Comment 4 2012-07-11 12:24:21 PDT
Created attachment 151749 [details] Patch with ChangeLog My apologies, I had forgotten to rebase the repository before writing my changes, which causes some errors when patching the changelog. This latest patch should work, however.
Rob Buis
Comment 5 2012-07-11 14:05:02 PDT
Comment on attachment 151749 [details] Patch with ChangeLog LGTM.
Konrad Piascik
Comment 6 2012-07-11 14:18:34 PDT
Comment on attachment 151749 [details] Patch with ChangeLog rebase your commit
Pawel Chomicki
Comment 7 2012-07-11 14:35:51 PDT
Created attachment 151779 [details] Patch with ChangeLog
Pawel Chomicki
Comment 8 2012-07-11 14:36:42 PDT
Created attachment 151781 [details] Patch with ChangeLog
Rob Buis
Comment 9 2012-07-11 15:10:14 PDT
Comment on attachment 151781 [details] Patch with ChangeLog LGTM.
WebKit Review Bot
Comment 10 2012-07-11 15:14:30 PDT
Comment on attachment 151781 [details] Patch with ChangeLog Rejecting attachment 151781 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 FAILED at 5760. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13207404
Pawel Chomicki
Comment 11 2012-07-11 17:22:26 PDT
Created attachment 151819 [details] Patch with ChangeLog
Kentaro Hara
Comment 12 2012-07-11 23:59:29 PDT
(Though I am not intending to say a strong opinion since this is a blackberry patch, FYI,) basically WebKit does not accept only-style-fix patches, which just messes up history.
Antonio Gomes
Comment 13 2012-07-12 07:32:35 PDT
(In reply to comment #12) > (Though I am not intending to say a strong opinion since this is a blackberry patch, FYI,) basically WebKit does not accept only-style-fix patches, which just messes up history. Agree. Please fix it as part of another patch, or when effectively touching this piece of code.
Note You need to log in before you can comment on or make changes to this bug.