RESOLVED FIXED 90991
[Chromium] Enable LEGACY_VIEWPORT_ADAPTION 
https://bugs.webkit.org/show_bug.cgi?id=90991
Summary [Chromium] Enable LEGACY_VIEWPORT_ADAPTION
Adam Barth
Reported 2012-07-11 10:33:10 PDT
[Chromium] Enable LEGACY_VIEWPORT_ADAPTION
Attachments
Patch (3.28 KB, patch)
2012-07-11 10:34 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-07-11 10:34:28 PDT
Created attachment 151730 [details] Patch
Dana Jansens
Comment 2 2012-07-11 10:40:03 PDT
Is there a nice summary of what this flag is meant to do? First time I heard of it :) What is this mobileoptimized business meant to be?
Peter Beverloo
Comment 3 2012-07-11 10:43:50 PDT
LGTM from Android's side, good catch. This will also enable the feature on Desktop when viewports themselves are enabled.
Adam Barth
Comment 4 2012-07-11 10:45:24 PDT
If you look at the tests that this patch "fixes", you can get a good sense of what the feature does. Basically, it causes us to recognize a bunch of old ways of indicating content for mobile phones and then scaling the viewport appropriately. We ship this feature on chromium-android (it's enabled in the branch). We could just enable it there, but we generally like to minimize the differences between Chromium on various platforms, so I thought we should enable it everywhere that supports the viewport tag.
Dana Jansens
Comment 5 2012-07-11 10:50:04 PDT
I see, thanks for the info.
WebKit Review Bot
Comment 6 2012-07-11 13:02:27 PDT
Comment on attachment 151730 [details] Patch Clearing flags on attachment: 151730 Committed r122359: <http://trac.webkit.org/changeset/122359>
WebKit Review Bot
Comment 7 2012-07-11 13:02:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.