Bug 90991 - [Chromium] Enable LEGACY_VIEWPORT_ADAPTION
Summary: [Chromium] Enable LEGACY_VIEWPORT_ADAPTION
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency tree / graph
 
Reported: 2012-07-11 10:33 PDT by Adam Barth
Modified: 2012-07-11 13:02 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2012-07-11 10:34 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-07-11 10:33:10 PDT 
[Chromium] Enable LEGACY_VIEWPORT_ADAPTION
Comment 1 Adam Barth 2012-07-11 10:34:28 PDT 
Created attachment 151730 [details]
Patch
Comment 2 Dana Jansens 2012-07-11 10:40:03 PDT 
Is there a nice summary of what this flag is meant to do? First time I heard of it :) What is this mobileoptimized business meant to be?
Comment 3 Peter Beverloo 2012-07-11 10:43:50 PDT 
LGTM from Android's side, good catch. This will also enable the feature on Desktop when viewports themselves are enabled.
Comment 4 Adam Barth 2012-07-11 10:45:24 PDT 
If you look at the tests that this patch "fixes", you can get a good sense of what the feature does.  Basically, it causes us to recognize a bunch of old ways of indicating content for mobile phones and then scaling the viewport appropriately.  We ship this feature on chromium-android (it's enabled in the branch).  We could just enable it there, but we generally like to minimize the differences between Chromium on various platforms, so I thought we should enable it everywhere that supports the viewport tag.
Comment 5 Dana Jansens 2012-07-11 10:50:04 PDT 
I see, thanks for the info.
Comment 6 WebKit Review Bot 2012-07-11 13:02:27 PDT 
Comment on attachment 151730 [details]
Patch

Clearing flags on attachment: 151730

Committed r122359: <http://trac.webkit.org/changeset/122359>
Comment 7 WebKit Review Bot 2012-07-11 13:02:34 PDT 
All reviewed patches have been landed.  Closing bug.