Bug 90975 - jsc: Parse options before creating global data
Summary: jsc: Parse options before creating global data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Wingo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-11 05:07 PDT by Andy Wingo
Modified: 2012-07-11 10:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.23 KB, patch)
2012-07-11 05:10 PDT, Andy Wingo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Wingo 2012-07-11 05:07:09 PDT 
This patch moves the options parsing in "jsc" before the creation of the global data, so that --useJIT=no takes effect.

It also has a refactor (turning CommandLine into a class from a struct).  I can undo that if it's not the thing to do.
Comment 1 Andy Wingo 2012-07-11 05:10:04 PDT 
Created attachment 151689 [details]
Patch
Comment 2 Mark Lam 2012-07-11 10:23:36 PDT 
I don't have review privileges, but the change looks good to me.
Comment 3 WebKit Review Bot 2012-07-11 10:50:33 PDT 
Comment on attachment 151689 [details]
Patch

Clearing flags on attachment: 151689

Committed r122341: <http://trac.webkit.org/changeset/122341>
Comment 4 WebKit Review Bot 2012-07-11 10:50:38 PDT 
All reviewed patches have been landed.  Closing bug.