UNCONFIRMED90972
Renames WebDeviceOrientation to WebDeviceOrientationData, Part 1 
https://bugs.webkit.org/show_bug.cgi?id=90972
Summary Renames WebDeviceOrientation to WebDeviceOrientationData, Part 1
Amy Ousterhout
Reported 2012-07-11 04:44:40 PDT
Renames WebDeviceOrientation to WebDeviceOrientationData, Part 1
Attachments
Patch (17.44 KB, patch)
2012-07-11 06:55 PDT, Amy Ousterhout 		no flags
DetailsFormatted DiffDiff
Patch (15.84 KB, patch)
2012-07-11 07:35 PDT, Amy Ousterhout 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Amy Ousterhout
Comment 1 2012-07-11 06:55:15 PDT
Created attachment 151699 [details] Patch
Amy Ousterhout
Comment 2 2012-07-11 06:57:59 PDT
This patch should not be landed until lastOrientationNew is implemented in chromium (https://chromiumcodereview.appspot.com/10735052/).
WebKit Review Bot
Comment 3 2012-07-11 06:58:54 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Build Bot
Comment 4 2012-07-11 07:05:47 PDT
Comment on attachment 151699 [details] Patch Attachment 151699 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13197035
Amy Ousterhout
Comment 5 2012-07-11 07:35:03 PDT
Created attachment 151705 [details] Patch
Eric Seidel (no email)
Comment 6 2012-08-12 03:34:18 PDT
I'm confused why adding "Data" is a naming improvement.
Note You need to log in before you can comment on or make changes to this bug.