Bug 90948 - [EFL] Move tests that require ENABLE_INPUT_TYPE_* to TestExpectations
Summary: [EFL] Move tests that require ENABLE_INPUT_TYPE_* to TestExpectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-11 00:47 PDT by Chris Dumez
Modified: 2012-07-11 02:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.40 KB, patch)
2012-07-11 00:49 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2012-07-11 00:52 PDT, Chris Dumez 		cdumez: commit-queue-
Details | Formatted Diff | Diff
Patch (2.75 KB, patch)
2012-07-11 00:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.75 KB, patch)
2012-07-11 01:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.27 KB, patch)
2012-07-11 01:01 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2012-07-11 01:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2012-07-11 01:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-11 00:47:24 PDT 
The fast/forms/input-in-table-cell-no-value.html introduced in r122290 is failing on EFL port because ENABLE_INPUT_TYPE_DATE flag is not enabled on EFL port.
Comment 1 Chris Dumez 2012-07-11 00:49:38 PDT 
Created attachment 151626 [details]
Patch

Could someone please cq+ ?
Comment 2 Chris Dumez 2012-07-11 00:52:06 PDT 
Created attachment 151629 [details]
Patch

Fix bug number.
Comment 3 Chris Dumez 2012-07-11 00:55:21 PDT 
Just received feedback from Bug 89209 that the date input might not be the issue for this failure after all. Marking cq- until we have a better understanding.
Comment 4 Chris Dumez 2012-07-11 00:58:42 PDT 
Created attachment 151631 [details]
Patch

Move only the other tests to TestExpectations for now.
Comment 5 Chris Dumez 2012-07-11 01:00:06 PDT 
Created attachment 151632 [details]
Patch

Fix typo.
Comment 6 Chris Dumez 2012-07-11 01:01:13 PDT 
Created attachment 151633 [details]
Patch
Comment 7 Chris Dumez 2012-07-11 01:05:00 PDT 
Created attachment 151635 [details]
Patch

Ok, now it was agreed in Bug 89209 that the new test should be skipped as well.
Comment 8 Chris Dumez 2012-07-11 01:06:18 PDT 
Created attachment 151638 [details]
Patch
Comment 9 WebKit Review Bot 2012-07-11 02:07:14 PDT 
Comment on attachment 151638 [details]
Patch

Clearing flags on attachment: 151638

Committed r122314: <http://trac.webkit.org/changeset/122314>
Comment 10 WebKit Review Bot 2012-07-11 02:07:25 PDT 
All reviewed patches have been landed.  Closing bug.