Bug 90946 - [EFL] svg/animations/dynamic-modify-attributename-crash2.svg is failing
Summary: [EFL] svg/animations/dynamic-modify-attributename-crash2.svg is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-11 00:22 PDT by Chris Dumez
Modified: 2012-07-11 00:29 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.36 KB, patch)
2012-07-11 00:25 PDT, Chris Dumez
inferno: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-11 00:22:41 PDT
svg/animations/dynamic-modify-attributename-crash2.svg is failing introduced in http://trac.webkit.org/changeset/122278 is failing on EFL port:

--- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/svg/animations/dynamic-modify-attributename-crash2-expected.txt
+++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/svg/animations/dynamic-modify-attributename-crash2-actual.txt
@@ -1 +1,3 @@
-PASS
+CONSOLE MESSAGE: line 20: ReferenceError: Can't find variable: gc
+FAIL: Timed out waiting for notifyDone to be called
+FAIL
Comment 1 Abhishek Arya 2012-07-11 00:24:03 PDT
Fix landed.
Comment 2 Chris Dumez 2012-07-11 00:25:44 PDT
Created attachment 151618 [details]
Patch
Comment 3 Chris Dumez 2012-07-11 00:26:52 PDT
Comment on attachment 151618 [details]
Patch

Oh OK.
Comment 4 Abhishek Arya 2012-07-11 00:27:37 PDT
Comment on attachment 151618 [details]
Patch

The fix has already landed. Anyway, we should always use gc() from js-test-pre.js and shouldn't define it as a null function.
Comment 5 Chris Dumez 2012-07-11 00:29:42 PDT
(In reply to comment #4)
> (From update of attachment 151618 [details])
> The fix has already landed. Anyway, we should always use gc() from js-test-pre.js and shouldn't define it as a null function.

My patch was inspired from LayoutTests/svg/animations/smil-element-not-removed-crash.html