Bug 90934 - Add dialog element feature toggle to InternalSettings
Summary: Add dialog element feature toggle to InternalSettings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Falkenhagen
URL:
Keywords:
Depends on:
Blocks: dialog-element 90931
  Show dependency tree / graph
 
Reported: 2012-07-10 21:31 PDT by Matt Falkenhagen
Modified: 2012-07-11 22:33 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.92 KB, patch)
2012-07-10 23:01 PDT, Matt Falkenhagen 		no flags Details | Formatted Diff | Diff
add to TestExpectations (12.72 KB, patch)
2012-07-10 23:44 PDT, Matt Falkenhagen 		no flags Details | Formatted Diff | Diff
sync (13.69 KB, patch)
2012-07-11 21:43 PDT, Matt Falkenhagen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Falkenhagen 2012-07-10 21:31:42 PDT 
Add dialog element feature toggle to InternalSettings, so layout tests can be written for dialog.
Comment 1 Matt Falkenhagen 2012-07-10 23:01:58 PDT 
Created attachment 151606 [details]
Patch
Comment 2 Matt Falkenhagen 2012-07-10 23:16:51 PDT 
Comment on attachment 151606 [details]
Patch

I should update text expectations for each platform since the feature is off at compile-time for all but Chromium. I'll upload a new patch with that.
Comment 3 Matt Falkenhagen 2012-07-10 23:44:05 PDT 
Created attachment 151613 [details]
add to TestExpectations
Comment 4 Hajime Morrita 2012-07-11 18:49:55 PDT 
Comment on attachment 151613 [details]
add to TestExpectations

Looks good,
Comment 5 WebKit Review Bot 2012-07-11 19:26:11 PDT 
Comment on attachment 151613 [details]
add to TestExpectations

Rejecting attachment 151613 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
m/efl/TestExpectations
patching file LayoutTests/platform/gtk/TestExpectations
Hunk #1 succeeded at 349 (offset 1 line).
patching file LayoutTests/platform/mac/TestExpectations
patching file LayoutTests/platform/qt/TestExpectations
Hunk #1 succeeded at 110 (offset 1 line).
patching file ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Hajime Mor..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13200574
Comment 6 Matt Falkenhagen 2012-07-11 21:43:03 PDT 
Created attachment 151853 [details]
sync
Comment 7 WebKit Review Bot 2012-07-11 22:33:20 PDT 
Comment on attachment 151853 [details]
sync

Clearing flags on attachment: 151853

Committed r122420: <http://trac.webkit.org/changeset/122420>
Comment 8 WebKit Review Bot 2012-07-11 22:33:31 PDT 
All reviewed patches have been landed.  Closing bug.