Bug 90929 - Chromium media element volume slider not functioning correctly at default size
Summary: Chromium media element volume slider not functioning correctly at default size
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-10 18:55 PDT by Cem Kocagil
Modified: 2013-04-15 08:00 PDT (History)
5 users (show)

See Also:


Attachments
Patch (354 bytes, patch)
2012-07-11 04:27 PDT, Cem Kocagil
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cem Kocagil 2012-07-10 18:55:34 PDT
Originally reported here: http://code.google.com/p/chromium/issues/detail?id=135272

As reported there, go to http://www.robtowns.com/music/come_thou_fount.mp3 (or open any audio file). The default audio element will have a width of 300px and the volume slider of 15px. However, the volume slider is not functioning correctly at that size.
Comment 1 Cem Kocagil 2012-07-11 04:27:10 PDT
Created attachment 151678 [details]
Patch

This patch should at least enable turning the volume on/off.
Comment 2 WebKit Review Bot 2012-07-11 04:30:00 PDT
Attachment 151678 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Cem Kocagil 2012-07-11 04:46:52 PDT
This patch should do it for now (except I forgot to update changelogs), but the following might be taken into consideration in the future for better functionality.

1) Currently, the volume slider logic seems unintuitive and produces many problems at low widget sizes. The slider bead doesn't move at the same speed as the mouse. It is also not always centered to the mouse, even when the mouse is in the range.
2) As suggested on the Chromium bug tracker, we can make it so that the full screen button will be hidden at small sizes.
3) As suggested on the Chromium bug tracker, the volume slider can be made to vertically pop up, similar to some Flash media players out there.
Comment 4 Silvia Pfeiffer 2012-07-11 07:01:06 PDT
The smaller widths are not being dealt with yet as specified - this is bug 89344. We've moved away from a vertical volume slider because it has created many other issues and will overlap other content such as captions.