Bug 90921 – [Chromium] Adjust DumpRenderTree ifdefs for Android

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Adam Barth]

[Chromium] Adjust DumpRenderTree ifdefs for Android

[Adam Barth]

Created attachment 151558 [details]
Patch

[Kent Tamura]

Comment on attachment 151558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151558&action=review

> Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h:-30
> -#if ENABLE(INPUT_SPEECH)
> -

Why do you remove it? Android port doesn't have INPUT_SPEECH, and this class shouldn't be needed, right?

[Adam Barth]

(In reply to comment #2)
> (From update of attachment 151558 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151558&action=review
> 
> > Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h:-30
> > -#if ENABLE(INPUT_SPEECH)
> > -
> 
> Why do you remove it? Android port doesn't have INPUT_SPEECH, and this class shouldn't be needed, right?

I suspect it's referenced outside the ENABLE(INPUT_SPEECH) ifdef.  We can try reverting it on the chromium-android branch, but it seemed easier to just upstream the change.

[Peter Beverloo]

Comment on attachment 151558 [details]
Patch

There is no reason for these changes to live upstream, as they seem to be merge errors in our downstream branch. We should abandon this and remove the differences downstream instead, for which I've uploaded this patch:

https://gerrit-int.chromium.org/#change,21574

Removing r? and cq? so it's clear to reviewers.

[Adam Barth]

Ok.