Bug 90905 - webkit-patch rebaseline doesn't work for audio/pixel tests
Summary: webkit-patch rebaseline doesn't work for audio/pixel tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-10 13:46 PDT by Ojan Vafai
Modified: 2012-07-11 12:25 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.14 KB, patch)
2012-07-10 13:47 PDT, Ojan Vafai 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-07-10 13:46:32 PDT 
webkit-patch rebaseline doesn't work for audio/pixel tests
Comment 1 Ojan Vafai 2012-07-10 13:47:54 PDT 
Created attachment 151514 [details]
Patch
Comment 2 Adam Barth 2012-07-10 13:50:57 PDT 
Comment on attachment 151514 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151514&action=review

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:421
> +                test_list[test][builder.name()] = self._suffixes_to_update(options)

I assume this does something sensible if the requested suffix doesn't exist on the server.
Comment 3 Ojan Vafai 2012-07-10 13:53:14 PDT 
(In reply to comment #2)
> (From update of attachment 151514 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151514&action=review
> 
> > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:421
> > +                test_list[test][builder.name()] = self._suffixes_to_update(options)
> 
> I assume this does something sensible if the requested suffix doesn't exist on the server.

Yup.
Comment 4 Ojan Vafai 2012-07-10 13:54:31 PDT 
Committed r122258: <http://trac.webkit.org/changeset/122258>
Comment 5 Dirk Pranke 2012-07-11 12:25:59 PDT 
Comment on attachment 151514 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151514&action=review

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:404
> +        return suffixes

minor nit ... if you specify the same suffix multiple times on the command line, this doesn't de-dup them, and it doesn't look like the underlying code checks for this either. Someone probably should :).