RESOLVED FIXED 90905
webkit-patch rebaseline doesn't work for audio/pixel tests 
https://bugs.webkit.org/show_bug.cgi?id=90905
Summary webkit-patch rebaseline doesn't work for audio/pixel tests
Ojan Vafai
Reported 2012-07-10 13:46:32 PDT
webkit-patch rebaseline doesn't work for audio/pixel tests
Attachments
Patch (9.14 KB, patch)
2012-07-10 13:47 PDT, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-07-10 13:47:54 PDT
Created attachment 151514 [details] Patch
Adam Barth
Comment 2 2012-07-10 13:50:57 PDT
Comment on attachment 151514 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151514&action=review > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:421 > + test_list[test][builder.name()] = self._suffixes_to_update(options) I assume this does something sensible if the requested suffix doesn't exist on the server.
Ojan Vafai
Comment 3 2012-07-10 13:53:14 PDT
(In reply to comment #2) > (From update of attachment 151514 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151514&action=review > > > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:421 > > + test_list[test][builder.name()] = self._suffixes_to_update(options) > > I assume this does something sensible if the requested suffix doesn't exist on the server. Yup.
Ojan Vafai
Comment 4 2012-07-10 13:54:31 PDT
Committed r122258: <http://trac.webkit.org/changeset/122258>
Dirk Pranke
Comment 5 2012-07-11 12:25:59 PDT
Comment on attachment 151514 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151514&action=review > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:404 > + return suffixes minor nit ... if you specify the same suffix multiple times on the command line, this doesn't de-dup them, and it doesn't look like the underlying code checks for this either. Someone probably should :).
Note You need to log in before you can comment on or make changes to this bug.