Bug 90897 - Line directive test in fast/canvas/webgl/glsl-conformance.html is incorrect
Summary: Line directive test in fast/canvas/webgl/glsl-conformance.html is incorrect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-10 11:21 PDT by Kenneth Russell
Modified: 2012-07-10 17:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.73 KB, patch)
2012-07-10 14:51 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
Patch for landing (3.83 KB, patch)
2012-07-10 15:09 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2012-07-10 11:21:17 PDT 
Alok Priyadarshi has recently rewritten the preprocessor in the ANGLE shader translator, and the rewrite has turned up a bug in the fast/canvas/webgl/glsl-conformance.html test of vshaderWithLineDirective. The test assumes that the error will occur on line 124, but according to the GLSL ES specification it should occur on line 123.

I am going to update the test to be correct and skip it on the majority of platforms. As ANGLE is updated in various ports to pick up the new preprocessor, the test can be enabled again.
Comment 1 Kenneth Russell 2012-07-10 14:48:18 PDT 
It turns out that this test is invalid (it is making assertions about the GLSL compiler's output not guaranteed by the spec). It's been removed from the WebGL conformance suite; we can just remove the test.
Comment 2 Kenneth Russell 2012-07-10 14:51:14 PDT 
Created attachment 151529 [details]
Patch
Comment 3 Adrienne Walker 2012-07-10 14:52:33 PDT 
Comment on attachment 151529 [details]
Patch

R=me.  Looks fine to me, but sad that the spec isn't testable.  :(
Comment 4 Kenneth Russell 2012-07-10 15:09:40 PDT 
Created attachment 151537 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-07-10 17:18:53 PDT 
Comment on attachment 151537 [details]
Patch for landing

Clearing flags on attachment: 151537

Committed r122281: <http://trac.webkit.org/changeset/122281>
Comment 6 WebKit Review Bot 2012-07-10 17:18:58 PDT 
All reviewed patches have been landed.  Closing bug.