Bug 90897 – Line directive test in fast/canvas/webgl/glsl-conformance.html is incorrect

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

Alok Priyadarshi has recently rewritten the preprocessor in the ANGLE shader translator, and the rewrite has turned up a bug in the fast/canvas/webgl/glsl-conformance.html test of vshaderWithLineDirective. The test assumes that the error will occur on line 124, but according to the GLSL ES specification it should occur on line 123.

I am going to update the test to be correct and skip it on the majority of platforms. As ANGLE is updated in various ports to pick up the new preprocessor, the test can be enabled again.

[Kenneth Russell]

It turns out that this test is invalid (it is making assertions about the GLSL compiler's output not guaranteed by the spec). It's been removed from the WebGL conformance suite; we can just remove the test.

[Kenneth Russell]

Created attachment 151529 [details]
Patch

[Adrienne Walker]

Comment on attachment 151529 [details]
Patch

R=me.  Looks fine to me, but sad that the spec isn't testable.  :(

[Kenneth Russell]

Created attachment 151537 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 151537 [details]
Patch for landing

Clearing flags on attachment: 151537

Committed r122281: <http://trac.webkit.org/changeset/122281>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.