Bug 90895 - [Qt] Make GraphicsSurface::create function platform specific.
Summary: [Qt] Make GraphicsSurface::create function platform specific.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks: 90881
  Show dependency tree / graph
 
Reported: 2012-07-10 10:47 PDT by Zeno Albisser
Modified: 2012-07-10 11:08 PDT (History)
1 user (show)

See Also:

Attachments
patch for review. (3.03 KB, patch)
2012-07-10 10:54 PDT, Zeno Albisser 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2012-07-10 10:47:48 PDT 
In order to implement platform specific create behavior this function should be platform specific.
We need this to be able to do platform specific initialization based on the provided flags, when implementing GraphicsSurfaceGLX.
Comment 1 Zeno Albisser 2012-07-10 10:54:56 PDT 
Created attachment 151487 [details]
patch for review.
Comment 2 Noam Rosenthal 2012-07-10 10:58:29 PDT 
Comment on attachment 151487 [details]
patch for review.

Maybe we should combine this with the GLX patch? Otherwise it's hard to see the whole picture.
Comment 3 Zeno Albisser 2012-07-10 11:06:43 PDT 
Comment on attachment 151487 [details]
patch for review.

As discussed on IRC I will instead make the functions platformCreate / platformImport static and return the instance back from there.
Comment 4 Zeno Albisser 2012-07-10 11:08:27 PDT 
no separate patch needed.