Bug 90891 - [Gtk] fast/events/keydown-function-keys.html is failing
Summary: [Gtk] fast/events/keydown-function-keys.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-10 10:00 PDT by Zan Dobersek
Modified: 2012-07-11 11:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2012-07-10 10:12 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-07-10 10:00:05 PDT
The test fails because when F10 key press is simulated the context menu pops up.

This is a known bug with recent xkeyboard-config version, reported at GNOME Bugzilla:
https://bugzilla.gnome.org/show_bug.cgi?id=661973

There's a workaround for this until that bug gets resolved, posted at Launchpad:
https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/937822/comments/5
This can be used, with effect, in DumpRenderTree.
Comment 1 Zan Dobersek 2012-07-10 10:12:00 PDT
Created attachment 151480 [details]
Patch
Comment 2 Martin Robinson 2012-07-10 10:13:26 PDT
Comment on attachment 151480 [details]
Patch

I guess we'll need this fix for WebKitTestRunner as well...
Comment 3 Zan Dobersek 2012-07-10 10:38:24 PDT
(In reply to comment #2)
> (From update of attachment 151480 [details])
> I guess we'll need this fix for WebKitTestRunner as well...

True, but WebKitTestRunner doesn't currently set up any GtkCSSProviders before testing.
Comment 4 Martin Robinson 2012-07-10 11:40:43 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 151480 [details] [details])
> > I guess we'll need this fix for WebKitTestRunner as well...
> 
> True, but WebKitTestRunner doesn't currently set up any GtkCSSProviders before testing.

It hasn't needed to up to this point because the GtkCSSProviders was added to make DRT match the non-native scrollbar of WebKitTestRunner.
Comment 5 Zan Dobersek 2012-07-11 00:03:13 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 151480 [details] [details] [details])
> > > I guess we'll need this fix for WebKitTestRunner as well...
> > 
> > True, but WebKitTestRunner doesn't currently set up any GtkCSSProviders before testing.
> 
> It hasn't needed to up to this point because the GtkCSSProviders was added to make DRT match the non-native scrollbar of WebKitTestRunner.

Oddly enough the test passes in WebKitTestRunner without unbinding the F10 key, so it seems there's no need for a GtkCSSProvider in WKTR.
Comment 6 WebKit Review Bot 2012-07-11 11:42:22 PDT
Comment on attachment 151480 [details]
Patch

Clearing flags on attachment: 151480

Committed r122349: <http://trac.webkit.org/changeset/122349>
Comment 7 WebKit Review Bot 2012-07-11 11:42:28 PDT
All reviewed patches have been landed.  Closing bug.