Bug 90877 – WebSocket.send() should accept ArrayBufferView

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Yuta Kitamura]

This is a child bug of bug 85961.

[Yuta Kitamura]

Created attachment 151637 [details]
Patch

[Kinuko Yasuda]

Comment on attachment 151637 [details]
Patch

(Drive-by comment)

View in context: https://bugs.webkit.org/attachment.cgi?id=151637&action=review

> Source/WebCore/Modules/websockets/WebSocket.cpp:294
> +    return m_channel->send(*binaryData, 0, binaryData->byteLength()) == ThreadableWebSocketChannel::SendSuccess;

Might be nicer to show deprecation warning message (and optionally collect metrics) if ArrayBuffer is given as well as we do in Blob constructor and XHR.send?

[Yuta Kitamura]

Created attachment 151861 [details]
Patch v2

[Yuta Kitamura]

Comment on attachment 151637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151637&action=review

>> Source/WebCore/Modules/websockets/WebSocket.cpp:294
>> +    return m_channel->send(*binaryData, 0, binaryData->byteLength()) == ThreadableWebSocketChannel::SendSuccess;
> 
> Might be nicer to show deprecation warning message (and optionally collect metrics) if ArrayBuffer is given as well as we do in Blob constructor and XHR.send?

Thanks, I added these in patch v2.

[Kent Tamura]

Comment on attachment 151861 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=151861&action=review

> Source/WebCore/ChangeLog:16
> +        Also, histogram metrics collection is added in WebSocket.send() to keep track of
> +        the usage of WebSocket.send() family.

This can be a separated patch.

[Yuta Kitamura]

Comment on attachment 151861 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=151861&action=review

http://dev.w3.org/html5/websockets/

WebSocket API draft was updated and now it includes *both* send(ArrayBuffer) and
send(ArrayBufferView). So, deprecation warning for send(ArrayBuffer) does not
make sense, thus I'm going to update the patch to remove it.

>> Source/WebCore/ChangeLog:16
>> +        the usage of WebSocket.send() family.
> 
> This can be a separated patch.

Will be removed.

[Yuta Kitamura]

Created attachment 156830 [details]
Patch v3

[Kent Tamura]

Comment on attachment 156830 [details]
Patch v3

Looks good.

[WebKit Review Bot]

Comment on attachment 156830 [details]
Patch v3

Clearing flags on attachment: 156830

Committed r124846: <http://trac.webkit.org/changeset/124846>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.