The tests under webintents/* expect the WebKitTestRunner to print out information about new intent requests and new intent services registration. Several test cases should start passing once the information is printed by WTR. We will then need to implement testRunner.deliverWebIntent() and testRunner.sendWebIntentResponse() to get more test cases to pass (probably in a separate patch).
Created attachment 151446 [details] Patch
Comment on attachment 151446 [details] Patch Attachment 151446 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13186087
Created attachment 151456 [details] Patch Should fix Qt-WK2 build issue.
Attachment 151456 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/WebProcess/qt/QtBuiltinBundlePage.cpp:80: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 151458 [details] Patch
Comment on attachment 151458 [details] Patch Though this is a little huge to review, looks good to me. BTW, I wonder how many test cases are covered by this patch? If this patch can cover webintents test cases, please write it to ChangeLog as well.
(In reply to comment #6) > (From update of attachment 151458 [details]) > Though this is a little huge to review, looks good to me. BTW, I wonder how many test cases are covered by this patch? If this patch can cover webintents test cases, please write it to ChangeLog as well. The Changelog already states: "Print out information about new intents requests and intent services registrations in WebKitTestRunner. This is expected by tests under webintents/*." So the change is covered by pretty much all the tests under webintents/*. How do you suggest I improve the changelog?
Comment on attachment 151458 [details] Patch Clearing flags on attachment: 151458 Committed r123374: <http://trac.webkit.org/changeset/123374>
All reviewed patches have been landed. Closing bug.