Bug 90868 - [EFL] WebKit DRT and WTR fail to build due to undefined reference to WTF::MD5::*
Summary: [EFL] WebKit DRT and WTR fail to build due to undefined reference to WTF::MD5::*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-10 03:23 PDT by Chris Dumez
Modified: 2012-07-10 05:03 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2012-07-10 03:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-10 03:23:39 PDT 
We get the following linking errors on the EFL build bot:

CMakeFiles/DumpRenderTree.dir/__/cairo/PixelDumpSupportCairo.cpp.o: In function `computeMD5HashStringForBitmapContext(BitmapContext*, char*)':
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:75: undefined reference to `WTF::MD5::MD5()'
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:78: undefined reference to `WTF::MD5::addBytes(unsigned char const*, unsigned long)'
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:82: undefined reference to `WTF::MD5::checksum(WTF::Vector<unsigned char, 16ul>&)'
collect2: ld returned 1 exit status
Comment 1 Chris Dumez 2012-07-10 03:29:11 PDT 
Created attachment 151427 [details]
Patch

Could someone please validate and cq+ ?
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-07-10 03:39:34 PDT 
Comment on attachment 151427 [details]
Patch

Looks sane, it looks like I shouldn't have removed ${WTF_LIBRARY_NAME} in r109983...
Comment 3 WebKit Review Bot 2012-07-10 05:03:09 PDT 
Comment on attachment 151427 [details]
Patch

Clearing flags on attachment: 151427

Committed r122213: <http://trac.webkit.org/changeset/122213>
Comment 4 WebKit Review Bot 2012-07-10 05:03:14 PDT 
All reviewed patches have been landed.  Closing bug.