Bug 90864 – RTL calendar picker for <input type=date> is too narrow and clipped

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

http://code.google.com/p/chromium/issues/detail?id=135421

A calendar picker is too narrow if user's date setting is for an RTL language.
This affects only desktop Chromium.

[Kent Tamura]

Created attachment 151422 [details]
Patch

[Kentaro Hara]

Comment on attachment 151422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151422&action=review

> Source/WebCore/Resources/calendarPicker.js:319
> +        yearMonthEnd = startOffset - yearMonthRightElement.offsetLeft;
> +        daysAreaEnd = startOffset - (daysAreaElement.offsetLeft + daysAreaElement.offsetWidth) + maxCellWidth * 7 + DaysAreaContainerBorder;

For daysAreaEnd, daysAreaElement.offsetWidth is subtracted from startOffset. On the other hand, for yearMonthEnd, yearMonthRightElement.offsetWidth is not subtracted from startOffset. Why?

[Kent Tamura]

Comment on attachment 151422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151422&action=review

>> Source/WebCore/Resources/calendarPicker.js:319
>> +        daysAreaEnd = startOffset - (daysAreaElement.offsetLeft + daysAreaElement.offsetWidth) + maxCellWidth * 7 + DaysAreaContainerBorder;
> 
> For daysAreaEnd, daysAreaElement.offsetWidth is subtracted from startOffset. On the other hand, for yearMonthEnd, yearMonthRightElement.offsetWidth is not subtracted from startOffset. Why?

For yearMonthEnd, we need the distance from the right edge of "main" to the left edge of yearMonthRightElement.
For daysAreaEnd, we need the sum of the followings:
 o the distane from the right edge of "main" to the right edge of the daysAreaElement
 o 7 * maxCellWidth
 o DaysAreaContainerBorder.

We don't use the left edge of the daysAreaElement because we'd like to assign the same width (maxCellWidth) for each of day-of-week columns.

[Kentaro Hara]

Comment on attachment 151422 [details]
Patch

Thanks for the clarification. rs=me

[Kent Tamura]

Comment on attachment 151422 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 151422 [details]
Patch

Clearing flags on attachment: 151422

Committed r122212: <http://trac.webkit.org/changeset/122212>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.