Since the conclusion was to discontinue the effort for QtWebKit-V8 (http://lists.webkit.org/pipermail/webkit-qt/2012-June/thread.html#2871) we should remove all the codepaths and configuration options which were introduced for building with V8.
Burn!
These guys want to see the show too :D
Gabor has started working on this.
Created attachment 152517 [details] Patch
Comment on attachment 152517 [details] Patch Attachment 152517 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13245885
Comment on attachment 152517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152517&action=review Looks good in general, a few small nitpicks > Source/WebCore/DerivedSources.pri:621 > -v8: wrapperFactoryArg = --wrapperFactoryV8 > -else: wrapperFactoryArg = --wrapperFactory > +wrapperFactoryArg = --wrapperFactory You could eliminate the variable entirely I think > Source/WebCore/DerivedSources.pri:638 > svgnames.extra_sources = SVGElementFactory.cpp > -v8 { > - svgnames.extra_sources += V8SVGElementWrapperFactory.cpp > -} else { > svgnames.extra_sources += JSSVGElementWrapperFactory.cpp You could merge line 637 and 638 or at least remove the indentation in 638 :) > Source/WebCore/DerivedSources.pri:695 > +generator = JS Same here, I think you could just get rid of the generator variable and pass --generator JS directly
Comment on attachment 152517 [details] Patch r=me if you do the small fix-ups I suggested before landing.
Committed r122834: <http://trac.webkit.org/changeset/122834>
Re-opened since this is blocked by 91492
Created attachment 152737 [details] Remove v8 from QtWebKit
Comment on attachment 152737 [details] Remove v8 from QtWebKit Rejecting attachment 152737 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13276141
Comment on attachment 152737 [details] Remove v8 from QtWebKit Clearing flags on attachment: 152737 Committed r122845: <http://trac.webkit.org/changeset/122845>
All reviewed patches have been landed. Closing bug.