Bug 90853 - Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
Summary: Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 81371
  Show dependency treegraph
 
Reported: 2012-07-10 00:37 PDT by Adam Barth
Modified: 2012-07-10 13:40 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.39 KB, patch)
2012-07-10 00:38 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (81.60 KB, patch)
2012-07-10 09:28 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-05 (394.54 KB, application/zip)
2012-07-10 10:02 PDT, WebKit Review Bot
no flags Details
Patch (82.90 KB, patch)
2012-07-10 10:08 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-07-10 00:37:05 PDT
Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
Comment 1 Adam Barth 2012-07-10 00:38:27 PDT
Created attachment 151409 [details]
Patch
Comment 2 Yuta Kitamura 2012-07-10 00:44:36 PDT
Thank you for doing this! The patch looks good to me. (I'm not a reviewer so please have some other reviewer to review this.)
Comment 3 Kent Tamura 2012-07-10 01:17:01 PDT
Comment on attachment 151409 [details]
Patch

Looks good.
Comment 4 Kent Tamura 2012-07-10 04:53:06 PDT
Comment on attachment 151409 [details]
Patch

Tests still have     testRunner.overridePreference("WebKitHixie76WebSocketProtocolEnabled", 0), and it produces a console message if the patch is applied.
Comment 5 Adam Barth 2012-07-10 08:05:40 PDT
Ah, will fix.
Comment 6 Adam Barth 2012-07-10 09:28:50 PDT
Created attachment 151468 [details]
Patch
Comment 7 WebKit Review Bot 2012-07-10 10:02:34 PDT
Comment on attachment 151468 [details]
Patch

Attachment 151468 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13209018

New failing tests:
http/tests/inspector/websocket/web-socket-frame.html
http/tests/inspector/web-socket-frame-error.html
Comment 8 WebKit Review Bot 2012-07-10 10:02:38 PDT
Created attachment 151475 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 9 Adam Barth 2012-07-10 10:08:10 PDT
Created attachment 151479 [details]
Patch
Comment 10 WebKit Review Bot 2012-07-10 13:40:07 PDT
Comment on attachment 151479 [details]
Patch

Clearing flags on attachment: 151479

Committed r122256: <http://trac.webkit.org/changeset/122256>
Comment 11 WebKit Review Bot 2012-07-10 13:40:11 PDT
All reviewed patches have been landed.  Closing bug.