Bug 90825 - [chromium] Remove HashMap workaround for layers with id=0 in CCDamageTracker
Summary: [chromium] Remove HashMap workaround for layers with id=0 in CCDamageTracker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on: 90573
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-09 14:58 PDT by Dana Jansens
Modified: 2012-07-09 17:17 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2012-07-09 14:59 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (2.83 KB, patch)
2012-07-09 15:03 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch for landing (2.88 KB, patch)
2012-07-09 15:46 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-07-09 14:58:13 PDT
[chromium] Remove HashMap workaround for layers with id=0 in CCDamageTracker
Comment 1 Dana Jansens 2012-07-09 14:59:24 PDT
Created attachment 151326 [details]
Patch
Comment 2 Dana Jansens 2012-07-09 15:00:05 PDT
(tests will fail until bug #90573 lands)
Comment 3 Adrienne Walker 2012-07-09 15:01:24 PDT
Can you also add an assert to CCDamageTracker::saveRectForNextFrame that layerId > 0?
Comment 4 Dana Jansens 2012-07-09 15:03:23 PDT
yuppers.
Comment 5 Dana Jansens 2012-07-09 15:03:37 PDT
Created attachment 151327 [details]
Patch
Comment 6 Adrienne Walker 2012-07-09 15:04:18 PDT
Comment on attachment 151327 [details]
Patch

R=me.  Thanks.  :)
Comment 7 WebKit Review Bot 2012-07-09 15:43:54 PDT
Comment on attachment 151327 [details]
Patch

Rejecting attachment 151327 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
hics/chromium/cc/CCHeadsUpDisplay.o
Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp: In member function 'void WebCore::CCDamageTracker::saveRectForNextFrame(int, const WebCore::FloatRect&)':
Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp:189: error: 'layerId' was not declared in this scope
make: *** [out/Debug/obj.target/webcore_chromium_compositor/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/13172245
Comment 8 Dana Jansens 2012-07-09 15:46:11 PDT
Created attachment 151334 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-07-09 17:17:40 PDT
Comment on attachment 151334 [details]
Patch for landing

Clearing flags on attachment: 151334

Committed r122170: <http://trac.webkit.org/changeset/122170>
Comment 10 WebKit Review Bot 2012-07-09 17:17:45 PDT
All reviewed patches have been landed.  Closing bug.