RESOLVED FIXED 90813
Refactor common Pointer Lock test code to a harness. 
https://bugs.webkit.org/show_bug.cgi?id=90813
Summary Refactor common Pointer Lock test code to a harness.
Vincent Scheib
Reported 2012-07-09 12:39:22 PDT
Refactor common Pointer Lock test code to a harness.
Attachments
Patch (24.27 KB, patch)
2012-07-09 12:43 PDT, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch (20.79 KB, patch)
2012-07-09 13:59 PDT, Vincent Scheib 		enne: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vincent Scheib
Comment 1 2012-07-09 12:43:24 PDT
Created attachment 151301 [details] Patch
Adrienne Walker
Comment 2 2012-07-09 13:22:01 PDT
Comment on attachment 151301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151301&action=review > LayoutTests/pointer-lock/resources/pointer-lock-test-harness.js:5 > + doNextStepButton.innerText = "doNextStep button for manual testing. Use keyboard to select and press (TAB, then SPACE) when pointer locked."; What about only adding the button or the text if there isn't a window.testRunner, so that this text doesn't get baked into every expectation file?
Vincent Scheib
Comment 3 2012-07-09 13:59:57 PDT
Created attachment 151311 [details] Patch
Vincent Scheib
Comment 4 2012-07-09 14:01:01 PDT
Comment on attachment 151301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151301&action=review >> LayoutTests/pointer-lock/resources/pointer-lock-test-harness.js:5 >> + doNextStepButton.innerText = "doNextStep button for manual testing. Use keyboard to select and press (TAB, then SPACE) when pointer locked."; > > What about only adding the button or the text if there isn't a window.testRunner, so that this text doesn't get baked into every expectation file? Done.
Adrienne Walker
Comment 5 2012-07-09 14:05:01 PDT
Comment on attachment 151311 [details] Patch R=me.
Vincent Scheib
Comment 6 2012-07-09 14:19:35 PDT
Committed r122158: <http://trac.webkit.org/changeset/122158>
Note You need to log in before you can comment on or make changes to this bug.