Bug 90813 - Refactor common Pointer Lock test code to a harness.
Summary: Refactor common Pointer Lock test code to a harness.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vincent Scheib
URL:
Keywords:
Depends on:
Blocks: 77029
  Show dependency tree / graph
 
Reported: 2012-07-09 12:39 PDT by Vincent Scheib
Modified: 2012-07-09 14:19 PDT (History)
1 user (show)

See Also:

Attachments
Patch (24.27 KB, patch)
2012-07-09 12:43 PDT, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Patch (20.79 KB, patch)
2012-07-09 13:59 PDT, Vincent Scheib 		enne: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2012-07-09 12:39:22 PDT 
Refactor common Pointer Lock test code to a harness.
Comment 1 Vincent Scheib 2012-07-09 12:43:24 PDT 
Created attachment 151301 [details]
Patch
Comment 2 Adrienne Walker 2012-07-09 13:22:01 PDT 
Comment on attachment 151301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151301&action=review

> LayoutTests/pointer-lock/resources/pointer-lock-test-harness.js:5
> +    doNextStepButton.innerText = "doNextStep button for manual testing. Use keyboard to select and press (TAB, then SPACE) when pointer locked.";

What about only adding the button or the text if there isn't a window.testRunner, so that this text doesn't get baked into every expectation file?
Comment 3 Vincent Scheib 2012-07-09 13:59:57 PDT 
Created attachment 151311 [details]
Patch
Comment 4 Vincent Scheib 2012-07-09 14:01:01 PDT 
Comment on attachment 151301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151301&action=review

>> LayoutTests/pointer-lock/resources/pointer-lock-test-harness.js:5
>> +    doNextStepButton.innerText = "doNextStep button for manual testing. Use keyboard to select and press (TAB, then SPACE) when pointer locked.";
> 
> What about only adding the button or the text if there isn't a window.testRunner, so that this text doesn't get baked into every expectation file?

Done.
Comment 5 Adrienne Walker 2012-07-09 14:05:01 PDT 
Comment on attachment 151311 [details]
Patch

R=me.
Comment 6 Vincent Scheib 2012-07-09 14:19:35 PDT 
Committed r122158: <http://trac.webkit.org/changeset/122158>