WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 90797
[GTK] Implement disk cache in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=90797
Summary
[GTK] Implement disk cache in WebKit2
Carlos Garcia Campos
Reported
2012-07-09 09:45:25 PDT
We currently set the disk cache size to the soup cache feature if it's present in the SoupSession, but it never happens because we are not adding the feature to the session.
Attachments
Patch
(5.18 KB, patch)
2012-07-09 09:49 PDT
,
Carlos Garcia Campos
xan.lopez
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2012-07-09 09:49:54 PDT
Created
attachment 151262
[details]
Patch
Martin Robinson
Comment 2
2012-07-09 10:07:01 PDT
I think it makes sense for Sergio and Dan to look this one over too.
Dan Winship
Comment 3
2012-07-10 06:32:46 PDT
makes sense to me
Xan Lopez
Comment 4
2012-07-13 04:54:27 PDT
Comment on
attachment 151262
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=151262&action=review
> Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp:92 > + uint64_t diskFreeSize = getCacheDiskFreeSize(cache) / 1024 / 1024;
Apparently this was a previously existing bug. Just leave it as it is for this patch and fix it later in another patch, otherwise it's unclear why you are doing this.
Carlos Garcia Campos
Comment 5
2012-07-13 06:47:21 PDT
Committed
r122571
: <
http://trac.webkit.org/changeset/122571
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug