Bug 90785 - [EFL][UT] Delete shutdown method.
Summary: [EFL][UT] Delete shutdown method.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-09 06:26 PDT by Krzysztof Czech
Modified: 2012-08-12 04:26 PDT (History)
7 users (show)

See Also:


Attachments
shutdown method is not needed. (1.84 KB, patch)
2012-07-09 06:30 PDT, Krzysztof Czech
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2012-07-09 06:26:31 PDT
Delete shutdown method from EWKTestBase class.
Comment 1 Krzysztof Czech 2012-07-09 06:30:27 PDT
Created attachment 151245 [details]
shutdown method is not needed.
Comment 2 Thiago Marcos P. Santos 2012-07-11 04:51:38 PDT
LGTM.
Comment 3 Gyuyoung Kim 2012-07-11 08:53:32 PDT
Comment on attachment 151245 [details]
shutdown method is not needed.

Looks fine. BTW, in my humble opinion, isn't it better to use shutdown() instead of shutdownAll() in order to be in sync with init() ?
Comment 4 Krzysztof Czech 2012-07-12 00:48:42 PDT
(In reply to comment #3)
> (From update of attachment 151245 [details])
> Looks fine. BTW, in my humble opinion, isn't it better to use shutdown() instead of shutdownAll() in order to be in sync with init() ?

I will take a look at it, thanks
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-07-12 13:05:55 PDT
I disagree with this approach for the same reason I mentioned in <https://bugs.webkit.org/show_bug.cgi?id=90606#c7>: you shouldn't need to loop to call the shutdown() functions; if you called _init() once, you should need to call _shutdown() only once. If it doesn't return 0, there's some unbalanced call somewhere.
Comment 6 Eric Seidel (no email) 2012-08-12 03:39:06 PDT
Comment on attachment 151245 [details]
shutdown method is not needed.

rs=me.
Comment 7 WebKit Review Bot 2012-08-12 04:26:19 PDT
Comment on attachment 151245 [details]
shutdown method is not needed.

Clearing flags on attachment: 151245

Committed r125369: <http://trac.webkit.org/changeset/125369>
Comment 8 WebKit Review Bot 2012-08-12 04:26:24 PDT
All reviewed patches have been landed.  Closing bug.