Delete shutdown method from EWKTestBase class.
Created attachment 151245 [details] shutdown method is not needed.
LGTM.
Comment on attachment 151245 [details] shutdown method is not needed. Looks fine. BTW, in my humble opinion, isn't it better to use shutdown() instead of shutdownAll() in order to be in sync with init() ?
(In reply to comment #3) > (From update of attachment 151245 [details]) > Looks fine. BTW, in my humble opinion, isn't it better to use shutdown() instead of shutdownAll() in order to be in sync with init() ? I will take a look at it, thanks
I disagree with this approach for the same reason I mentioned in <https://bugs.webkit.org/show_bug.cgi?id=90606#c7>: you shouldn't need to loop to call the shutdown() functions; if you called _init() once, you should need to call _shutdown() only once. If it doesn't return 0, there's some unbalanced call somewhere.
Comment on attachment 151245 [details] shutdown method is not needed. rs=me.
Comment on attachment 151245 [details] shutdown method is not needed. Clearing flags on attachment: 151245 Committed r125369: <http://trac.webkit.org/changeset/125369>
All reviewed patches have been landed. Closing bug.