Bug 90784 - [WK2] Add missing Battery Status API integration to WebContext and WebPage
Summary: [WK2] Add missing Battery Status API integration to WebContext and WebPage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 90069
  Show dependency treegraph
 
Reported: 2012-07-09 06:04 PDT by Chris Dumez
Modified: 2012-07-09 13:46 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.15 KB, patch)
2012-07-09 06:13 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (9.82 KB, patch)
2012-07-09 07:37 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-09 06:04:39 PDT
Some code is needed in WebContext and WebPage in order for the Battery Status test cases to pass with WebKitTestRunner:
- We need to call WebCore::provideBatteryTo() in WebPage
- We need to add the WebBatteryManagerProxy to WebContext and properly direct messages to it
Comment 1 Chris Dumez 2012-07-09 06:13:38 PDT
Created attachment 151243 [details]
Patch
Comment 2 Chris Dumez 2012-07-09 07:37:17 PDT
Created attachment 151248 [details]
Patch

Add corresponding C API function in WKContext to retrieve the Battery manager.
Comment 3 WebKit Review Bot 2012-07-09 13:46:24 PDT
Comment on attachment 151248 [details]
Patch

Clearing flags on attachment: 151248

Committed r122153: <http://trac.webkit.org/changeset/122153>
Comment 4 WebKit Review Bot 2012-07-09 13:46:30 PDT
All reviewed patches have been landed.  Closing bug.