WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 90776
[Gtk] Unskip the Shadow DOM layout tests
https://bugs.webkit.org/show_bug.cgi?id=90776
Summary
[Gtk] Unskip the Shadow DOM layout tests
Zan Dobersek
Reported
2012-07-09 04:15:39 PDT
[Gtk] Unskip the Shadow DOM layout tests
Attachments
Patch
(9.15 KB, patch)
2012-07-09 04:29 PDT
,
Zan Dobersek
rniwa
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2012-07-09 04:29:47 PDT
Created
attachment 151231
[details]
Patch
WebKit Review Bot
Comment 2
2012-07-09 04:34:03 PDT
Attachment 151231
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:126: The parameter name "enabled" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 3
2012-07-13 15:40:05 PDT
Comment on
attachment 151231
[details]
Patch rs=me.
Zan Dobersek
Comment 4
2012-09-24 11:32:48 PDT
(In reply to
comment #3
)
> (From update of
attachment 151231
[details]
) > rs=me.
Thanks! This bug somehow fell off my radar. Updated and commited:
http://trac.webkit.org/changeset/129391
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug