Bug 90776 - [Gtk] Unskip the Shadow DOM layout tests
Summary: [Gtk] Unskip the Shadow DOM layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-09 04:15 PDT by Zan Dobersek
Modified: 2012-09-24 11:32 PDT (History)
1 user (show)

See Also:

Attachments
Patch (9.15 KB, patch)
2012-07-09 04:29 PDT, Zan Dobersek 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-07-09 04:15:39 PDT 
[Gtk] Unskip the Shadow DOM layout tests
Comment 1 Zan Dobersek 2012-07-09 04:29:47 PDT 
Created attachment 151231 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-09 04:34:03 PDT 
Attachment 151231 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:126:  The parameter name "enabled" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2012-07-13 15:40:05 PDT 
Comment on attachment 151231 [details]
Patch

rs=me.
Comment 4 Zan Dobersek 2012-09-24 11:32:48 PDT 
(In reply to comment #3)
> (From update of attachment 151231 [details])
> rs=me.

Thanks! This bug somehow fell off my radar. Updated and commited:
http://trac.webkit.org/changeset/129391