Bug 90767 - [GTK] Inspector should set a default attached height before being attached
Summary: [GTK] Inspector should set a default attached height before being attached
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-07-09 03:03 PDT by Carlos Garcia Campos
Modified: 2012-08-02 10:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.89 KB, patch)
2012-07-09 03:08 PDT, Carlos Garcia Campos 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-07-09 03:03:43 PDT 
We are currently using the minimum attached height in WebKitWebViewBase as the default height for the inspector when attached. It would be easier for WebKitWebViewBase and embedders implementing attach() if the inspector already had an attached height set when it's being attached.
Comment 1 Carlos Garcia Campos 2012-07-09 03:08:12 PDT 
Created attachment 151221 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-09 03:10:44 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Xan Lopez 2012-08-02 07:13:09 PDT 
Comment on attachment 151221 [details]
Patch

This looks reasonable to me, but I'm not an expert in this area of the code. Maybe martin wants to have a second look.
Comment 4 Martin Robinson 2012-08-02 07:18:45 PDT 
Comment on attachment 151221 [details]
Patch

This looks sane to me.
Comment 5 Carlos Garcia Campos 2012-08-02 10:44:52 PDT 
Committed r124479: <http://trac.webkit.org/changeset/124479>