RESOLVED FIXED 90767
[GTK] Inspector should set a default attached height before being attached 
https://bugs.webkit.org/show_bug.cgi?id=90767
Summary [GTK] Inspector should set a default attached height before being attached
Carlos Garcia Campos
Reported 2012-07-09 03:03:43 PDT
We are currently using the minimum attached height in WebKitWebViewBase as the default height for the inspector when attached. It would be easier for WebKitWebViewBase and embedders implementing attach() if the inspector already had an attached height set when it's being attached.
Attachments
Patch (5.89 KB, patch)
2012-07-09 03:08 PDT, Carlos Garcia Campos 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-07-09 03:08:12 PDT
Created attachment 151221 [details] Patch
WebKit Review Bot
Comment 2 2012-07-09 03:10:44 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Xan Lopez
Comment 3 2012-08-02 07:13:09 PDT
Comment on attachment 151221 [details] Patch This looks reasonable to me, but I'm not an expert in this area of the code. Maybe martin wants to have a second look.
Martin Robinson
Comment 4 2012-08-02 07:18:45 PDT
Comment on attachment 151221 [details] Patch This looks sane to me.
Carlos Garcia Campos
Comment 5 2012-08-02 10:44:52 PDT
Committed r124479: <http://trac.webkit.org/changeset/124479>
Note You need to log in before you can comment on or make changes to this bug.