Bug 90766 – Register protocol handler files should be in Modules/protocolhandler

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

In my humble opinion, NavigatorRegisterProtocolHandler files is able to be moved to Modules. This modules is self-contained. However, I'm not sure whether Bug 82266 should be landed first. If not so, files related to protocol handler should be moved to the modules.

[Gyuyoung Kim]

Created attachment 151220 [details]
Patch for EFL ,GTK and QT port

[Gyuyoung Kim]

CC'ing Adam and Hajime.

[Build Bot]

Comment on attachment 151220 [details]
Patch for EFL ,GTK and QT port

Attachment 151220 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13167171

[WebKit Review Bot]

Comment on attachment 151220 [details]
Patch for EFL ,GTK and QT port

Attachment 151220 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13157785

[Build Bot]

Comment on attachment 151220 [details]
Patch for EFL ,GTK and QT port

Attachment 151220 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13156885

[Adam Barth]

protocolhandler is listed under "Current Non-Modules Using Module-Related Techniques for Loose Coupling" rather than "Possibly Planned Modules, Based on Previous Emails and the Spreadsheet":

http://lists.webkit.org/pipermail/webkit-dev/2012-February/019628.html

The conversation progressed somewhat after that email, but that's a reasonably snapshot of our thinking about this topic back in February.  Obviously, the things we discussed in that thread aren't set in stone, but you might want to review that thread before working on these sorts of changes.  If you think we should do something different than what we discussed then, you might want to start a new thread on webkit-dev about it.

[Gyuyoung Kim]

Created attachment 151264 [details]
Patch

[Hajime Morrita]

Comment on attachment 151264 [details]
Patch

Having the webkit-dev thread http://markmail.org/message/q3hvwjukeachf7sj got no objection, I'd r+ this.

[WebKit Review Bot]

Comment on attachment 151264 [details]
Patch

Rejecting attachment 151264 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ndler.cpp
rm 'Source/WebCore/page/NavigatorRegisterProtocolHandler.cpp'
patching file Source/WebCore/page/NavigatorRegisterProtocolHandler.h
rm 'Source/WebCore/page/NavigatorRegisterProtocolHandler.h'
patching file Source/WebCore/page/NavigatorRegisterProtocolHandler.idl
rm 'Source/WebCore/page/NavigatorRegisterProtocolHandler.idl'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Hajime Mor..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13205617

[Gyuyoung Kim]

Created attachment 151886 [details]
Patch

[WebKit Review Bot]

Comment on attachment 151886 [details]
Patch

Clearing flags on attachment: 151886

Committed r122445: <http://trac.webkit.org/changeset/122445>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.