Bug 90766 - Register protocol handler files should be in Modules/protocolhandler
Summary: Register protocol handler files should be in Modules/protocolhandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 90940
  Show dependency treegraph
 
Reported: 2012-07-09 02:59 PDT by Gyuyoung Kim
Modified: 2012-07-12 04:26 PDT (History)
6 users (show)

See Also:


Attachments
Patch for EFL ,GTK and QT port (29.86 KB, patch)
2012-07-09 03:00 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (51.80 KB, patch)
2012-07-09 10:03 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (51.54 KB, patch)
2012-07-12 01:51 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-07-09 02:59:05 PDT
In my humble opinion, NavigatorRegisterProtocolHandler files is able to be moved to Modules. This modules is self-contained. However, I'm not sure whether Bug 82266 should be landed first. If not so, files related to protocol handler should be moved to the modules.
Comment 1 Gyuyoung Kim 2012-07-09 03:00:36 PDT
Created attachment 151220 [details]
Patch for EFL ,GTK and QT port
Comment 2 Gyuyoung Kim 2012-07-09 03:01:43 PDT
CC'ing Adam and Hajime.
Comment 3 Build Bot 2012-07-09 03:05:58 PDT
Comment on attachment 151220 [details]
Patch for EFL ,GTK and QT port

Attachment 151220 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13167171
Comment 4 WebKit Review Bot 2012-07-09 03:07:38 PDT
Comment on attachment 151220 [details]
Patch for EFL ,GTK and QT port

Attachment 151220 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13157785
Comment 5 Build Bot 2012-07-09 03:22:00 PDT
Comment on attachment 151220 [details]
Patch for EFL ,GTK and QT port

Attachment 151220 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13156885
Comment 6 Adam Barth 2012-07-09 08:57:12 PDT
protocolhandler is listed under "Current Non-Modules Using Module-Related Techniques for Loose Coupling" rather than "Possibly Planned Modules, Based on Previous Emails and the Spreadsheet":

http://lists.webkit.org/pipermail/webkit-dev/2012-February/019628.html

The conversation progressed somewhat after that email, but that's a reasonably snapshot of our thinking about this topic back in February.  Obviously, the things we discussed in that thread aren't set in stone, but you might want to review that thread before working on these sorts of changes.  If you think we should do something different than what we discussed then, you might want to start a new thread on webkit-dev about it.
Comment 7 Gyuyoung Kim 2012-07-09 10:03:55 PDT
Created attachment 151264 [details]
Patch
Comment 8 Hajime Morrita 2012-07-12 01:11:54 PDT
Comment on attachment 151264 [details]
Patch

Having the webkit-dev thread http://markmail.org/message/q3hvwjukeachf7sj got no objection, I'd r+ this.
Comment 9 WebKit Review Bot 2012-07-12 01:33:09 PDT
Comment on attachment 151264 [details]
Patch

Rejecting attachment 151264 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ndler.cpp
rm 'Source/WebCore/page/NavigatorRegisterProtocolHandler.cpp'
patching file Source/WebCore/page/NavigatorRegisterProtocolHandler.h
rm 'Source/WebCore/page/NavigatorRegisterProtocolHandler.h'
patching file Source/WebCore/page/NavigatorRegisterProtocolHandler.idl
rm 'Source/WebCore/page/NavigatorRegisterProtocolHandler.idl'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Hajime Mor..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13205617
Comment 10 Gyuyoung Kim 2012-07-12 01:51:29 PDT
Created attachment 151886 [details]
Patch
Comment 11 WebKit Review Bot 2012-07-12 04:26:44 PDT
Comment on attachment 151886 [details]
Patch

Clearing flags on attachment: 151886

Committed r122445: <http://trac.webkit.org/changeset/122445>
Comment 12 WebKit Review Bot 2012-07-12 04:26:50 PDT
All reviewed patches have been landed.  Closing bug.