Bug 90760 - [EFL] Battery status code needs refactoring to be reused in WebKit2
Summary: [EFL] Battery status code needs refactoring to be reused in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 90069
  Show dependency tree / graph
 
Reported: 2012-07-09 00:33 PDT by Chris Dumez
Modified: 2012-07-09 23:43 PDT (History)
6 users (show)

See Also:

Attachments
Patch (28.92 KB, patch)
2012-07-09 00:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-09 00:33:45 PDT 
We need to make the distinction between the BatteryProviderEfl which should be in WebCore and the BatteryClientEfl which should be in WebKit. We also need to define a BatteryProviderEflClient interface so that it can be implemented by clients.
Comment 1 Chris Dumez 2012-07-09 00:43:20 PDT 
Created attachment 151201 [details]
Patch
Comment 2 Gyuyoung Kim 2012-07-09 03:51:13 PDT 
Comment on attachment 151201 [details]
Patch

Looks good refactoring.
Comment 3 WebKit Review Bot 2012-07-09 23:42:56 PDT 
Comment on attachment 151201 [details]
Patch

Clearing flags on attachment: 151201

Committed r122197: <http://trac.webkit.org/changeset/122197>
Comment 4 WebKit Review Bot 2012-07-09 23:43:01 PDT 
All reviewed patches have been landed.  Closing bug.