Bug 90735 - [EFL] REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html is crashing
Summary: [EFL] REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html is crashing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-08 01:16 PDT by Chris Dumez
Modified: 2012-07-08 20:51 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.04 KB, patch)
2012-07-08 02:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.05 KB, patch)
2012-07-08 02:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-08 01:16:35 PDT 
The crash looks like:

crash log for DumpRenderTree (pid 27037):
STDOUT: <empty>
STDERR: ASSERTION FAILED: this
STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/dom/Node.h(412) : WebCore::Document* WebCore::Node::document() const
STDERR: 1   0x7fca92305f4b
STDERR: 2   0x7fca92305252
STDERR: 3   0x7fca95268636 WebCore::Document::webkitExitFullscreen()
STDERR: 4   0x7fca95268321 WebCore::Document::webkitCancelFullScreen()
STDERR: 5   0x7fca95e0f0bc WebCore::jsDocumentPrototypeFunctionWebkitCancelFullScreen(JSC::ExecState*)
STDERR: 6   0x7fca47033265

We can inspire from http://trac.webkit.org/changeset/122035/trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp to fix the crash.
Comment 1 Chris Dumez 2012-07-08 02:06:33 PDT 
Created attachment 151161 [details]
Patch
Comment 2 Chris Dumez 2012-07-08 02:10:25 PDT 
Created attachment 151162 [details]
Patch

Add [EFL] tag.
Comment 3 WebKit Review Bot 2012-07-08 20:51:43 PDT 
Comment on attachment 151162 [details]
Patch

Clearing flags on attachment: 151162

Committed r122078: <http://trac.webkit.org/changeset/122078>
Comment 4 WebKit Review Bot 2012-07-08 20:51:48 PDT 
All reviewed patches have been landed.  Closing bug.