Bug 90733 – [GStreamer] cache video dimensions

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

There's no need to query the video-sink sink-pad caps every time in ::naturalSize(). We can simply cache this size every time the pad caps change and reuse the value by returning early from ::naturalSize().

[Philippe Normand]

Created attachment 151151 [details]
Patch

[Martin Robinson]

Comment on attachment 151151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151151&action=review

The logic is a bit hard to follow here. Perhaps you could do this:

1. naturalSize() would be responsible for caching. m_videoSize.
2. In notifyPlayerOfVideo when you want to invalidate the cached video size simply do:

    m_videoSize = IntSize();

and then let naturalSize() initialize m_videoSize lazily.

[Philippe Normand]

(In reply to comment #2)
> (From update of attachment 151151 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151151&action=review
> 
> The logic is a bit hard to follow here. Perhaps you could do this:
> 
> 1. naturalSize() would be responsible for caching. m_videoSize.

That's not possible unfortunately because naturalSize() is const :/

> 2. In notifyPlayerOfVideo when you want to invalidate the cached video size simply do:
> 
>     m_videoSize = IntSize();
> 

That I can do yes! :)

[Martin Robinson]

(In reply to comment #3)

> That's not possible unfortunately because naturalSize() is const :/

In these situations, I typically just make the cache member mutable.

[Philippe Normand]

Created attachment 151153 [details]
Patch

[Philippe Normand]

Committed r122187: <http://trac.webkit.org/changeset/122187>