Bug 9073 – [S60] Soft hyphen (­ and ­ and ­) is not displayed

• Status: CLOSED
• Resolution: FIXED
• Component: Text

[Krishna]

Character entities of soft hyphen (­ and ­ and ­) are not rendered when line break occurs.

Steps to reproduce:
1. Load the attached file
2. There are three paras displayed and a soft hyphen is not displayed at the line breaks.
Actual result: Soft hyphen is not displayed at the end of each line.
Expected result: Soft hyphen is expected at the end of each line for each paragraph; i.e. at the point at which the line wraps.

[Krishna]

Created attachment 8492 [details]
soft_hyphen.html

[David Kilzer (:ddkilzer)]

Interesting.  In FireFox 1.5.0.3, no wrapping occurs at all!  Works ask expected in MSIE 6 from WinXP SP 2.

Note that there are a couple of "stray" semi-colons (without the preceding "&shy") in the "para1" line in Attachment 8492 [details].

[Dave Hyatt]

This is S60 only presumably.  The test case works fine for me in TOT Safari.

[Dave Hyatt]

Firefox does not support soft hyphens so don't pay attention to it.

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> Firefox does not support soft hyphens so don't pay attention to it.

Gecko bug:  https://bugzilla.mozilla.org/show_bug.cgi?id=9101

[Dave Hyatt]

I just landed a fix for this for Win32 that you can backport to S60.  See my most recent change to rendering/break_lines.cpp.

[David Kilzer (:ddkilzer)]

(In reply to comment #6)
> I just landed a fix for this for Win32 that you can backport to S60.  See my
> most recent change to rendering/break_lines.cpp.

Subversion revision r14601.

[David Carson]

Changes. For reference:
http://anoncvs.opensource.apple.com/svn/diff.php?repname=WebKit&path=%2Ftrunk%2FWebCore%2Frendering%2Fbreak_lines.cpp&rev=14601&sc=1

[David Carson]

Tried the patch, and it didn't make any noticable difference in S60 emulator. Need to debug to see what is going on.

[Krishna]

TSW Error ID: AKUR-6H9EAC

[David Carson]

Created attachment 8631 [details]
patch

Patch includes updated expected results for layout tests, changelog and patch. Also includes a missing expected results file for the layout tests.

[Sachin Padma]

r=me

[alan]

(In reply to comment #11)
> Created an attachment (id=8631) [edit]
> patch
> 
> Patch includes updated expected results for layout tests, changelog and patch.
> Also includes a missing expected results file for the layout tests.
> 
r=me

[Darin Adler]

Adding S60 prefix to summary of platform-only bugs with reviewed patches, so we can see if there are non-S60 ones in the review queue.

[Bradley Morrison]

Applied (r15638). Verified against latest S60WebKit via layout test with index 927 (X:\S60\LayoutTests\fast\text\basic\014.html).

Many thanks!

[Krishna]

As this is S60 only issue, verified on the S60 Webkit at r15648.

The issue is no longer reproducible. 
Soft hyphen is displayed at the end of each line for each
paragraph; i.e. at the point at which the line wraps.

Resolution is set to VERIFIED.

[Krishna]

Set to CLOSED.