Bug 90713 – Consider closing unused localStorage database after a timeout.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Yongjun Zhang]

We should consider closing the underlying sqlite database if there is no active document referencing it.  We can do this after a timeout to avoid closing and opening the same database too often, e.g., when user is doing back/forward navigation.

[Yongjun Zhang]

Created attachment 151124 [details]
close unused sqlite db after 300 seconds.

[WebKit Review Bot]

Attachment 151124 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/WebCore/storage/StorageAreaImpl.cpp:277:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gyuyoung Kim]

Comment on attachment 151124 [details]
close unused sqlite db after 300 seconds.

Attachment 151124 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13156263

[WebKit Review Bot]

Comment on attachment 151124 [details]
close unused sqlite db after 300 seconds.

Attachment 151124 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13151498

[Build Bot]

Comment on attachment 151124 [details]
close unused sqlite db after 300 seconds.

Attachment 151124 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13157247

[Yongjun Zhang]

Created attachment 151131 [details]
Fix build and style issues.

[WebKit Review Bot]

Attachment 151131 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Tools/ChangeLog:3:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp:1489:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/storage/StorageAreaImpl.cpp:279:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/storage/StorageArea.h:59:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/storage/StorageArea.h:60:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 9 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yongjun Zhang]

Created attachment 151132 [details]
Fix more style issues.

[Simon Fraser (smfr)]

Comment on attachment 151132 [details]
Fix more style issues.

View in context: https://bugs.webkit.org/attachment.cgi?id=151132&action=review

> Source/WebCore/storage/StorageAreaImpl.cpp:277
> +    --m_accessCount;

This should assert that it doesn't go negative.

[Brady Eidson]

Comment on attachment 151132 [details]
Fix more style issues.

View in context: https://bugs.webkit.org/attachment.cgi?id=151132&action=review

Let's go one more pass

> Source/WebCore/storage/StorageTracker.cpp:51
> +// If there is no document referecing a storage database, close the underlying database
> +// after it has been idle for s_StorageDatabaseIdleInterval seconds.
> +static const double StorageDatabaseIdleInterval = 300;

typo "referecing"

s_StorageDatabaseIdleInterval should be m_StorageDatabaseIdleInterval?

And StorageDatabaseIdleInterval should be "DefaultStorageDatabaseIdleInterval"

[Yongjun Zhang]

Created attachment 151293 [details]
Addressing review comments.

[WebKit Review Bot]

Comment on attachment 151293 [details]
Addressing review comments. 

Rejecting attachment 151293 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13165455

[Yongjun Zhang]

Created attachment 151359 [details]
Reviewed patch for commit.

[WebKit Review Bot]

Comment on attachment 151359 [details]
Reviewed patch for commit.

Clearing flags on attachment: 151359

Committed r122174: <http://trac.webkit.org/changeset/122174>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

Build fix landed in http://trac.webkit.org/changeset/122177.

[Jer Noble]

This patch added no support for testRunner.setStorageDatabaseIdleInterval() on WK2.  Thus, this new test is failing on all WK2 ports.