Bug 90705 - [Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
Summary: [Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-06 14:50 PDT by Lauro Moura Maranhao Neto
Modified: 2012-07-06 15:45 PDT (History)
1 user (show)

See Also:

Attachments
Use QImage.constBits instead of bits (1.66 KB, patch)
2012-07-06 14:55 PDT, Lauro Moura Maranhao Neto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura Maranhao Neto 2012-07-06 14:50:16 PDT 
getImageData is using non-const QImage.bits() as the first argument to packPixels, which expects a const uchar*. This is causing a deep copy of the QImage for each call.
Comment 1 Lauro Moura Maranhao Neto 2012-07-06 14:55:02 PDT 
Created attachment 151118 [details]
Use QImage.constBits instead of bits
Comment 2 WebKit Review Bot 2012-07-06 15:45:12 PDT 
Comment on attachment 151118 [details]
Use QImage.constBits instead of bits

Clearing flags on attachment: 151118

Committed r122037: <http://trac.webkit.org/changeset/122037>
Comment 3 WebKit Review Bot 2012-07-06 15:45:16 PDT 
All reviewed patches have been landed.  Closing bug.