Bug 90686 - Web Inspector: show loaders memory consumption on the memory chart
Summary: Web Inspector: show loaders memory consumption on the memory chart
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 87262
  Show dependency treegraph
 
Reported: 2012-07-06 06:56 PDT by Yury Semikhatsky
Modified: 2012-07-17 22:59 PDT (History)
15 users (show)

See Also:


Attachments
Patch draft (8.67 KB, patch)
2012-07-06 07:59 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (12.80 KB, patch)
2012-07-17 05:53 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (18.77 KB, patch)
2012-07-17 07:50 PDT, Ilya Tikhonovsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-07-06 06:56:06 PDT
Size of FrameLoader, DocumentLoader, ResourceLoader and their resources should be shown on the memory pie chart.
Comment 1 Yury Semikhatsky 2012-07-06 07:59:51 PDT
Created attachment 151083 [details]
Patch draft
Comment 2 Early Warning System Bot 2012-07-06 08:16:57 PDT
Comment on attachment 151083 [details]
Patch draft

Attachment 151083 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13140508
Comment 3 Early Warning System Bot 2012-07-06 08:20:59 PDT
Comment on attachment 151083 [details]
Patch draft

Attachment 151083 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13140509
Comment 4 Build Bot 2012-07-06 10:39:22 PDT
Comment on attachment 151083 [details]
Patch draft

Attachment 151083 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13155316
Comment 5 Ilya Tikhonovsky 2012-07-17 05:53:49 PDT
Created attachment 152746 [details]
Patch
Comment 6 Build Bot 2012-07-17 06:32:13 PDT
Comment on attachment 152746 [details]
Patch

Attachment 152746 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13272140
Comment 7 Ilya Tikhonovsky 2012-07-17 07:50:20 PDT
Created attachment 152762 [details]
Patch
Comment 8 Pavel Feldman 2012-07-17 13:09:35 PDT
Comment on attachment 152762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152762&action=review

> Source/WebCore/loader/ResourceLoader.cpp:533
> +    printf("ResourceLoader: %u\n", m_resourceData ? m_resourceData->size() : 0);

Please remove this logging.
Comment 9 Ilya Tikhonovsky 2012-07-17 22:59:06 PDT
Committed r122920: <http://trac.webkit.org/changeset/122920>