Bug 90684 - Web Inspector: get rid of cancellable records in Timeline, manage frame records explicitly
Summary: Web Inspector: get rid of cancellable records in Timeline, manage frame recor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-06 06:41 PDT by Andrey Kosyakov
Modified: 2012-07-06 09:41 PDT (History)
8 users (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2012-07-06 06:53 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-07-06 06:41:05 PDT 
Bringing in a notion of generic "cancelable" records in Timeline agent was a bad idea -- we don't seem to have other uses for it, and current implementation that uses records stack is somewhat confusing. Let's manage pending frame record explicitly instead.
Comment 1 Andrey Kosyakov 2012-07-06 06:53:30 PDT 
Created attachment 151079 [details]
Patch
Comment 2 Andrey Kosyakov 2012-07-06 09:41:23 PDT 
Committed r121980: <http://trac.webkit.org/changeset/121980>