I figured it'd be better to discuss this in a bug report than coordinating with the lists for the EFL and GTK+ ports at the same time. glibc seems to have recently deprecated the gets() call following the C11 standard. gnutls ships with a bundled Gnulib, and the version shipped with the 2.x series fails to build after this change in glibc. The problem was fixed in Gnulib in <http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=66712c23388e93e5c518ebc8515140fa0c807348>, which is present on gnutls 3.0.21, for example. I don't know what's currently holding us at gnutls 2.x, so I'd like some input from you guys as to how to proceed here.
Created attachment 151174 [details] Update gnutls to 3.0.21
(In reply to comment #1) > Created an attachment (id=151174) [details] > Update gnutls to 3.0.21 I briefly talked about this issue with mrobinson on IRC a few days ago, but we did not decide whether it made sense to stop building gnutls with jhbuild or not. For now, this patch just updates the gnutls version we build.
Comment on attachment 151174 [details] Update gnutls to 3.0.21 Attachment 151174 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13164128
Comment on attachment 151174 [details] Update gnutls to 3.0.21 Attachment 151174 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13045090
Created attachment 154107 [details] Depend on nettle to hopefully build on the bots
Comment on attachment 154107 [details] Depend on nettle to hopefully build on the bots Attachment 154107 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13323713
Created attachment 154125 [details] Do not remove libgcrypt from EFL's jhbuild.modules
It currently seems to fail only on Philippe's bot when building nettle: checking for __gmpz_getlimbn in -lgmp... no configure: WARNING: GNU MP not found, or not 3.1 or up, see http://gmplib.org/. Support for public key algorithms will be unavailable. checking for __gmpz_powm_sec... no Philippe, could you check if GMP is installed there? I'd rather not include it in in jhbuild.modules.
I installed libgmp-dev on my EWS. I'll check the Igalia bots too.
Created attachment 154335 [details] Same patch to check if GMP is now present on the GTK bots
Created attachment 154359 [details] Try nettle 2.4 to see if it works on Philippe's bot
Comment on attachment 154359 [details] Try nettle 2.4 to see if it works on Philippe's bot Attachment 154359 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13348475
(In reply to comment #12) > (From update of attachment 154359 [details]) > Attachment 154359 [details] did not pass gtk-ews (gtk): > Output: http://queues.webkit.org/results/13348475 kov, can you install libgmp-dev on the bot as well?
Created attachment 155306 [details] New approach, just remove gnutls from jhbuild.modules
(In reply to comment #14) > Created an attachment (id=155306) [details] > New approach, just remove gnutls from jhbuild.modules As we just discussed on IRC, it looks like these days it is safe to just depend on the gnutls version installed on the system. On Ubuntu systems this would require at least Precise Pangolin.
Comment on attachment 155306 [details] New approach, just remove gnutls from jhbuild.modules Thanks!
Comment on attachment 155306 [details] New approach, just remove gnutls from jhbuild.modules Clearing flags on attachment: 155306 Committed r124094: <http://trac.webkit.org/changeset/124094>
All reviewed patches have been landed. Closing bug.
For the record, I added libgnutls-dev to the list of system deps at EFLWebKit wiki.