Currently CodeGeneratorInspector.py always overwrites all output files. This triggers a cascade of recompilations. Only write output, if it actually changed.
Created attachment 151003 [details] Patch
Comment on attachment 151003 [details] Patch Do you have numbers that would show how much time it saves? The generator shouldn't be called unless Inspector.json(which is relatively rare event) has changed in which case at least some output files should also change.
(In reply to comment #2) > (From update of attachment 151003 [details]) > Do you have numbers that would show how much time it saves? The generator shouldn't be called unless Inspector.json(which is relatively rare event) has changed in which case at least some output files should also change. I don't have numbers, but every time I develop code generator or do something related, I have to wait 1 extra minute per build, because incremental build doesn't work.
Comment on attachment 151003 [details] Patch Clearing flags on attachment: 151003 Committed r122739: <http://trac.webkit.org/changeset/122739>
All reviewed patches have been landed. Closing bug.
It appears that this patch broke Mac builds: http://build.webkit.org/builders/Apple%20Lion%20%28Leaks%29/builds/536/steps/compile-webkit/logs/stdio
(In reply to comment #6) > It appears that this patch broke Mac builds: > http://build.webkit.org/builders/Apple%20Lion%20%28Leaks%29/builds/536/steps/compile-webkit/logs/stdio I'm sorry to hear it. Our office opens in about 11 hours from now. If you need so, please feel free to roll the change back.
Re-opened since this is blocked by 91424
Created attachment 152808 [details] Add missing close
Comment on attachment 152808 [details] Add missing close Clearing flags on attachment: 152808 Committed r123091: <http://trac.webkit.org/changeset/123091>
If this is relanded, could you please remove the print " writing " ...? Thanks.
(In reply to comment #12) > If this is relanded, could you please remove the print " writing " ...? Thanks. https://bugs.webkit.org/show_bug.cgi?id=91758