Bug 90642 - Web Inspector: CodeGeneratorInspector.py: fix output write logic to support incremental build
Summary: Web Inspector: CodeGeneratorInspector.py: fix output write logic to support i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 91424
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-05 16:28 PDT by Peter Rybin
Modified: 2012-07-19 16:22 PDT (History)
13 users (show)

See Also:


Attachments
Patch (3.28 KB, patch)
2012-07-05 16:32 PDT, Peter Rybin
no flags Details | Formatted Diff | Diff
Add missing close (3.50 KB, patch)
2012-07-17 12:49 PDT, Peter Rybin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2012-07-05 16:28:12 PDT
Currently CodeGeneratorInspector.py always overwrites all output files. This triggers a cascade of recompilations.
Only write output, if it actually changed.
Comment 1 Peter Rybin 2012-07-05 16:32:22 PDT
Created attachment 151003 [details]
Patch
Comment 2 Yury Semikhatsky 2012-07-05 23:25:12 PDT
Comment on attachment 151003 [details]
Patch

Do you have numbers that would show how much time it saves? The generator shouldn't be called unless Inspector.json(which is relatively rare event) has changed in which case at least some output files should also change.
Comment 3 Peter Rybin 2012-07-16 10:21:16 PDT
(In reply to comment #2)
> (From update of attachment 151003 [details])
> Do you have numbers that would show how much time it saves? The generator shouldn't be called unless Inspector.json(which is relatively rare event) has changed in which case at least some output files should also change.

I don't have numbers, but every time I develop code generator or do something related, I have to wait 1 extra minute per build, because incremental build doesn't work.
Comment 4 WebKit Review Bot 2012-07-16 11:11:09 PDT
Comment on attachment 151003 [details]
Patch

Clearing flags on attachment: 151003

Committed r122739: <http://trac.webkit.org/changeset/122739>
Comment 5 WebKit Review Bot 2012-07-16 11:11:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryosuke Niwa 2012-07-16 13:15:56 PDT
It appears that this patch broke Mac builds:
http://build.webkit.org/builders/Apple%20Lion%20%28Leaks%29/builds/536/steps/compile-webkit/logs/stdio
Comment 7 Peter Rybin 2012-07-16 14:26:01 PDT
(In reply to comment #6)
> It appears that this patch broke Mac builds:
> http://build.webkit.org/builders/Apple%20Lion%20%28Leaks%29/builds/536/steps/compile-webkit/logs/stdio

I'm sorry to hear it.
Our office opens in about 11 hours from now. If you need so, please feel free to roll the change back.
Comment 8 WebKit Review Bot 2012-07-16 14:29:32 PDT
Re-opened since this is blocked by 91424
Comment 9 Peter Rybin 2012-07-17 12:49:05 PDT
Created attachment 152808 [details]
Add missing close
Comment 10 WebKit Review Bot 2012-07-19 04:50:26 PDT
Comment on attachment 152808 [details]
Add missing close

Clearing flags on attachment: 152808

Committed r123091: <http://trac.webkit.org/changeset/123091>
Comment 11 WebKit Review Bot 2012-07-19 04:50:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Scott Graham 2012-07-19 15:47:12 PDT
If this is relanded, could you please remove the print "  writing " ...? Thanks.
Comment 13 Peter Rybin 2012-07-19 16:22:45 PDT
(In reply to comment #12)
> If this is relanded, could you please remove the print "  writing " ...? Thanks.

https://bugs.webkit.org/show_bug.cgi?id=91758