Bug 90631 – Web Inspector: display function scope in UI

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Peter Rybin]

Function scope is already supported in WebKit Remote Debugging protocol.

[Peter Rybin]

Created attachment 151000 [details]
This is a draft only, please review on request only

[Yury Semikhatsky]

Comment on attachment 151000 [details]
This is a draft only, please review on request only

View in context: https://bugs.webkit.org/attachment.cgi?id=151000&action=review

> Source/WebCore/ChangeLog:8
> +        TBD

Please fill in the change description.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:251
> +            if (this.property.value.type == "function") {

We use === in the front-end code, also no braces for one-line blocks.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:500
> +                var subtitle = " ";

I'd rather assign it to null here.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:502
> +                switch (scope.type) {

style nit: "A case label should line up with its switch statement"

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:544
> +        this.hasChildren = true;

Why not initialize this in the constructor?

[Peter Rybin]

Created attachment 156437 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 156437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156437&action=review

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:451
> +WebInspector.ObjectPropertyTreeElement.Populate = function(treeElement, value) {

style: Populate -> populate

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:557
> +    onattach: function()

Please remove this and next methods.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:590
> +    onattach: function()

These two methods can also be removed.

[Peter Rybin]

Created attachment 156771 [details]
Patch

[WebKit Review Bot]

Comment on attachment 156771 [details]
Patch

Clearing flags on attachment: 156771

Committed r124876: <http://trac.webkit.org/changeset/124876>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.