Bug 90619 - Code refactoring: move mimeTypeFromUTITree to a separate file.
Summary: Code refactoring: move mimeTypeFromUTITree to a separate file.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-05 10:14 PDT by Yongjun Zhang
Modified: 2012-07-05 13:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.56 KB, patch)
2012-07-05 10:30 PDT, Yongjun Zhang
no flags Details | Formatted Diff | Diff
Patch, fix style violation in UTIUtilities.h. (15.55 KB, patch)
2012-07-05 10:35 PDT, Yongjun Zhang
ddkilzer: review+
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
Address review comments on previous patch. (15.25 KB, patch)
2012-07-05 12:47 PDT, Yongjun Zhang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2012-07-05 10:14:04 PDT
We should UTI handling code to a separate file.
Comment 1 Yongjun Zhang 2012-07-05 10:30:06 PDT
Created attachment 150954 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-05 10:32:57 PDT
Attachment 150954 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/network/mac/UTIUtilities.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yongjun Zhang 2012-07-05 10:35:46 PDT
Created attachment 150958 [details]
Patch, fix style violation in UTIUtilities.h.
Comment 4 David Kilzer (:ddkilzer) 2012-07-05 12:36:02 PDT
Comment on attachment 150958 [details]
Patch, fix style violation in UTIUtilities.h.

View in context: https://bugs.webkit.org/attachment.cgi?id=150958&action=review

r=me with the clause 3 license fixes.  (The WebCore Xcode project items are just nits I noticed, but can be checked in with this commit, or separately.)

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:7958
> -		333F704F0FB49CA2008E12A6 /* Notification.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Notification.h; path =Modules/notifications/Notification.h; sourceTree = "<group>"; };
> +		333F704F0FB49CA2008E12A6 /* Notification.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Notification.h; path = Modules/notifications/Notification.h; sourceTree = "<group>"; };

NOTE: Drive-by fix that happened when editing the Xcode project file.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:28176
> -				A8CCBB4C151F833B00AB7CE9 /* WorkerContextWebDatabase.cpp in Sources */, F34742E01343631F00531BC2 /* WorkerDebuggerAgent.cpp in Sources */,
> +				A8CCBB4C151F833B00AB7CE9 /* WorkerContextWebDatabase.cpp in Sources */,
> +				F34742E01343631F00531BC2 /* WorkerDebuggerAgent.cpp in Sources */,

NOTE: Drive-by fix that happened when editing the Xcode project file.

> Source/WebCore/platform/network/mac/UTIUtilities.h:15
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *     its contributors may be used to endorse or promote products derived
> + *     from this software without specific prior written permission. 

This is the old Apple license.  The one in Source/WebCore/LICENSE-APPLE doesn't include clause 3 anymore.  Please remove clause 3.

> Source/WebCore/platform/network/mac/UTIUtilities.mm:15
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *     its contributors may be used to endorse or promote products derived
> + *     from this software without specific prior written permission. 

Ditto re: removing clause 3.
Comment 5 Yongjun Zhang 2012-07-05 12:47:26 PDT
Created attachment 150973 [details]
Address review comments on previous patch.
Comment 6 WebKit Review Bot 2012-07-05 13:19:25 PDT
Comment on attachment 150973 [details]
Address review comments on previous patch.

Clearing flags on attachment: 150973

Committed r121923: <http://trac.webkit.org/changeset/121923>
Comment 7 WebKit Review Bot 2012-07-05 13:19:37 PDT
All reviewed patches have been landed.  Closing bug.