Bug 90610 - Web Inspector: move search field to the bottom of the page.
Summary: Web Inspector: move search field to the bottom of the page.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-05 07:00 PDT by Pavel Feldman
Modified: 2012-07-05 09:45 PDT (History)
10 users (show)

See Also:


Attachments
[IMAGE] with patch applied (5.97 KB, image/png)
2012-07-05 07:00 PDT, Pavel Feldman
no flags Details
Patch (18.96 KB, patch)
2012-07-05 08:09 PDT, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-07-05 07:00:00 PDT
This is the first step in the Search/replace implementation. This change moves search field from the inspector toolbar to the inspector view footer that is visible upon Cmd/Ctrl+F.
Comment 1 Pavel Feldman 2012-07-05 07:00:54 PDT
Created attachment 150936 [details]
[IMAGE] with patch applied
Comment 2 Pavel Feldman 2012-07-05 08:09:58 PDT
Created attachment 150942 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-07-05 09:17:09 PDT
Comment on attachment 150942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150942&action=review

Please make label and input font size the same.

> Source/WebCore/inspector/front-end/SearchController.js:-220
> -            // If focus belongs here and text is empty - nothing to do, return unhandled.

We need a close button on the footer as well.

> Source/WebCore/inspector/front-end/inspector.css:300
> +.toolbar-search-navigation-hidden {

Is this style used somewhere?

> Source/WebCore/inspector/front-end/inspector.css:462
>  .status-bar {

Please revert this.
Comment 4 Pavel Feldman 2012-07-05 09:45:02 PDT
Committed r121911: <http://trac.webkit.org/changeset/121911>