Bug 90591 – [BlackBerry] Make setForceDownload a setter method.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Mary Wu]

A small typo fix in ResourceRequest.h

[Mary Wu]

Created attachment 150889 [details]
Patch

[Rob Buis]

Comment on attachment 150889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150889&action=review

Fix is good, explanation could be improved :)

> Source/WebCore/ChangeLog:3
> +        [BlackBerry] A small typo fix in ResourceRequest.h

The bug title is not correct, this is not a typo!

> Source/WebCore/ChangeLog:7
> +

You could add something like "Make setForceDownload a setter method."

Also, is this API used yet? If so, you could indicate which current use-case it fixes.

[Mary Wu]

(In reply to comment #2)
> (From update of attachment 150889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150889&action=review
> 
> Fix is good, explanation could be improved :)
> 
> > Source/WebCore/ChangeLog:3
> > +        [BlackBerry] A small typo fix in ResourceRequest.h
> 
> The bug title is not correct, this is not a typo!

Thanks, I will change the title.

 
> > Source/WebCore/ChangeLog:7
> > +
> 
> You could add something like "Make setForceDownload a setter method."
> 
> Also, is this API used yet? If so, you could indicate which current use-case it fixes.

Right now the API was only used for true case...To "Make setForceDownload a setter method", we should either use the parameter or remove parameter from the API. I take the first.

[Mary Wu]

Created attachment 151178 [details]
Patch

[WebKit Review Bot]

Comment on attachment 151178 [details]
Patch

Clearing flags on attachment: 151178

Committed r122086: <http://trac.webkit.org/changeset/122086>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.