Bug 90591 - [BlackBerry] Make setForceDownload a setter method.
Summary: [BlackBerry] Make setForceDownload a setter method.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mary Wu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-05 01:28 PDT by Mary Wu
Modified: 2012-07-08 21:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2012-07-05 01:35 PDT, Mary Wu 		no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2012-07-08 21:07 PDT, Mary Wu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mary Wu 2012-07-05 01:28:21 PDT 
A small typo fix in ResourceRequest.h
Comment 1 Mary Wu 2012-07-05 01:35:10 PDT 
Created attachment 150889 [details]
Patch
Comment 2 Rob Buis 2012-07-05 07:03:23 PDT 
Comment on attachment 150889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150889&action=review

Fix is good, explanation could be improved :)

> Source/WebCore/ChangeLog:3
> +        [BlackBerry] A small typo fix in ResourceRequest.h

The bug title is not correct, this is not a typo!

> Source/WebCore/ChangeLog:7
> +

You could add something like "Make setForceDownload a setter method."

Also, is this API used yet? If so, you could indicate which current use-case it fixes.
Comment 3 Mary Wu 2012-07-08 20:43:36 PDT 
(In reply to comment #2)
> (From update of attachment 150889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150889&action=review
> 
> Fix is good, explanation could be improved :)
> 
> > Source/WebCore/ChangeLog:3
> > +        [BlackBerry] A small typo fix in ResourceRequest.h
> 
> The bug title is not correct, this is not a typo!

Thanks, I will change the title.

 
> > Source/WebCore/ChangeLog:7
> > +
> 
> You could add something like "Make setForceDownload a setter method."
> 
> Also, is this API used yet? If so, you could indicate which current use-case it fixes.

Right now the API was only used for true case...To "Make setForceDownload a setter method", we should either use the parameter or remove parameter from the API. I take the first.
Comment 4 Mary Wu 2012-07-08 21:07:56 PDT 
Created attachment 151178 [details]
Patch
Comment 5 WebKit Review Bot 2012-07-08 21:56:55 PDT 
Comment on attachment 151178 [details]
Patch

Clearing flags on attachment: 151178

Committed r122086: <http://trac.webkit.org/changeset/122086>
Comment 6 WebKit Review Bot 2012-07-08 21:57:00 PDT 
All reviewed patches have been landed.  Closing bug.