Bug 90585 - Skip platform/mac/editing/deleting/backward-delete.html on android
Summary: Skip platform/mac/editing/deleting/backward-delete.html on android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-04 22:03 PDT by Xingnan Wang
Modified: 2012-08-08 22:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2012-07-04 22:05 PDT, Xingnan Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xingnan Wang 2012-07-04 22:03:39 PDT
As this test only for mac.
Comment 1 Xingnan Wang 2012-07-04 22:05:30 PDT
Created attachment 150874 [details]
Patch
Comment 2 Adam Barth 2012-07-04 22:25:57 PDT
Is there a public buildbot for chromium-android?  It's not going to be possible to keep the TestExpectations file up-to-date without a public buildbot.
Comment 3 Xingnan Wang 2012-07-04 22:36:31 PDT
(In reply to comment #2)
> Is there a public buildbot for chromium-android?  It's not going to be possible to keep the TestExpectations file up-to-date without a public buildbot.

Do you mean this http://build.webkit.org/builders/Chromium%20Android%20Release?
Comment 4 Alexey Proskuryakov 2012-07-04 22:43:01 PDT
I think that Android should skip everything in platform/mac, not just a single test.
Comment 5 Xingnan Wang 2012-07-04 23:11:43 PDT
(In reply to comment #4)
> I think that Android should skip everything in platform/mac, not just a single test.

Agree, so I think we can use this
WONTFIX SKIP ANDROID : platform/mac = TEXT IMAGE IMAGE+TEXT PASS TIMEOUT CRASH
at top?
Comment 6 Adam Barth 2012-07-04 23:35:30 PDT
> Do you mean this http://build.webkit.org/builders/Chromium%20Android%20Release?

I mean one that runs tests.

> > I think that Android should skip everything in platform/mac, not just a single test.
> 
> Agree, so I think we can use this
> WONTFIX SKIP ANDROID : platform/mac = TEXT IMAGE IMAGE+TEXT PASS TIMEOUT CRASH
> at top?

That's not consistent with other Chromium ports.  We should ask the folks who made that decisions, but for some reason Chromium runs all the platform-specific tests for all the platforms.
Comment 7 Xingnan Wang 2012-08-08 20:21:12 PDT
(In reply to comment #6)
> > Do you mean this http://build.webkit.org/builders/Chromium%20Android%20Release?
> 
> I mean one that runs tests.
> 
> > > I think that Android should skip everything in platform/mac, not just a single test.
> > 
> > Agree, so I think we can use this
> > WONTFIX SKIP ANDROID : platform/mac = TEXT IMAGE IMAGE+TEXT PASS TIMEOUT CRASH
> > at top?
> 
> That's not consistent with other Chromium ports.  We should ask the folks who made that decisions, but for some reason Chromium runs all the platform-specific tests for all the platforms.

As Bug 92653 landed, can the one be reviewed now?
Comment 8 WebKit Review Bot 2012-08-08 22:21:43 PDT
Comment on attachment 150874 [details]
Patch

Clearing flags on attachment: 150874

Committed r125150: <http://trac.webkit.org/changeset/125150>
Comment 9 WebKit Review Bot 2012-08-08 22:21:47 PDT
All reviewed patches have been landed.  Closing bug.